Skip to content

Commit 2ec3182

Browse files
Dongsu Parkaxboe
Dongsu Park
authored andcommitted
Documentation: update notes in biovecs about arbitrarily sized bios
Update block/biovecs.txt so that it includes a note on what kind of effects arbitrarily sized bios would bring to the block layer. Also fix a trivial typo, bio_iter_iovec. Cc: Christoph Hellwig <[email protected]> Cc: Kent Overstreet <[email protected]> Cc: Jonathan Corbet <[email protected]> Cc: [email protected] Signed-off-by: Dongsu Park <[email protected]> Signed-off-by: Ming Lin <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent b54ffb7 commit 2ec3182

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

Documentation/block/biovecs.txt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ particular, presenting the illusion of partially completed biovecs so that
2424
normal code doesn't have to deal with bi_bvec_done.
2525

2626
* Driver code should no longer refer to biovecs directly; we now have
27-
bio_iovec() and bio_iovec_iter() macros that return literal struct biovecs,
27+
bio_iovec() and bio_iter_iovec() macros that return literal struct biovecs,
2828
constructed from the raw biovecs but taking into account bi_bvec_done and
2929
bi_size.
3030

@@ -109,3 +109,11 @@ Other implications:
109109
over all the biovecs in the new bio - which is silly as it's not needed.
110110

111111
So, don't use bi_vcnt anymore.
112+
113+
* The current interface allows the block layer to split bios as needed, so we
114+
could eliminate a lot of complexity particularly in stacked drivers. Code
115+
that creates bios can then create whatever size bios are convenient, and
116+
more importantly stacked drivers don't have to deal with both their own bio
117+
size limitations and the limitations of the underlying devices. Thus
118+
there's no need to define ->merge_bvec_fn() callbacks for individual block
119+
drivers.

0 commit comments

Comments
 (0)