Skip to content

Commit 3026fe9

Browse files
JamesH65Phil Elwell
authored and
Phil Elwell
committed
drm/vc4: Fix for margins in composite/SDTV mode (#3223)
Margins were incorrectly assumed to be setup in SDTV mode, but were not actually done, so this make the setup non-conditional on mode. Signed-off-by: James Hughes <[email protected]>
1 parent 088bb7d commit 3026fe9

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/gpu/drm/vc4/vc4_firmware_kms.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1588,14 +1588,9 @@ vc4_fkms_connector_init(struct drm_device *dev, struct drm_encoder *encoder,
15881588
connector->interlace_allowed = 0;
15891589
}
15901590

1591-
/* Create and attach TV margin props to this connector.
1592-
* Already done for SDTV outputs.
1593-
*/
1594-
if (fkms_connector->display_type != DRM_MODE_ENCODER_TVDAC) {
1595-
ret = drm_mode_create_tv_margin_properties(dev);
1596-
if (ret)
1597-
goto fail;
1598-
}
1591+
ret = drm_mode_create_tv_margin_properties(dev);
1592+
if (ret)
1593+
goto fail;
15991594

16001595
drm_connector_attach_tv_margin_properties(connector);
16011596

0 commit comments

Comments
 (0)