media: em28xx-cards: fix em28xx_duplicate_dev()

Dan Carpenter · mchehab · commit 3f127ce11353 · 2018-03-08T06:06:51.000-05:00
There is a double sizeof() typo here so we don't duplicate the struct properly. Fixes: be7fd3c ("media: em28xx: Hauppauge DualHD second tuner functionality") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -3515,7 +3515,7 @@ static int em28xx_duplicate_dev(struct em28xx *dev)
 		dev->dev_next = NULL;
 		return -ENOMEM;
 	}
-	memcpy(sec_dev, dev, sizeof(sizeof(*sec_dev)));
+	memcpy(sec_dev, dev, sizeof(*sec_dev));
 	/* Check to see next free device and mark as used */
 	do {
 		nr = find_first_zero_bit(em28xx_devused, EM28XX_MAXBOARDS);

Original file line number	Diff line number	Diff line change
`@@ -3515,7 +3515,7 @@ static int em28xx_duplicate_dev(struct em28xx *dev)`
`3515`	`3515`	`dev->dev_next = NULL;`
`3516`	`3516`	`return -ENOMEM;`
`3517`	`3517`	`}`
`3518`		`- memcpy(sec_dev, dev, sizeof(sizeof(*sec_dev)));`
	`3518`	`+ memcpy(sec_dev, dev, sizeof(*sec_dev));`
`3519`	`3519`	`/* Check to see next free device and mark as used */`
`3520`	`3520`	`do {`
`3521`	`3521`	`nr = find_first_zero_bit(em28xx_devused, EM28XX_MAXBOARDS);`