Skip to content

Commit 470d4f0

Browse files
Yiling Chenalexdeucher
Yiling Chen
authored andcommitted
drm/amd/display: Remove unnecessary eDP power down
[why] When first time of link training is fail, eDP would be powered down and would not be powered up for next retry link training. It causes that all of retry link linking would be fail. [how] We has extracted both power up and down sequence from enable/disable link output function before DCN32. We remov eDP power down in dcn32_disable_link_output(). Reviewed-by: Charlene Liu <[email protected]> Signed-off-by: Yiling Chen <[email protected]> Signed-off-by: Tom Chung <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]> (cherry picked from commit f5860c8)
1 parent 35ca53b commit 470d4f0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1398,12 +1398,12 @@ void dcn32_disable_link_output(struct dc_link *link,
13981398

13991399
link_hwss->disable_link_output(link, link_res, signal);
14001400
link->phy_state.symclk_state = SYMCLK_OFF_TX_OFF;
1401-
1402-
if (signal == SIGNAL_TYPE_EDP &&
1403-
link->dc->hwss.edp_power_control &&
1404-
!link->skip_implict_edp_power_control)
1405-
link->dc->hwss.edp_power_control(link, false);
1406-
else if (dmcu != NULL && dmcu->funcs->unlock_phy)
1401+
/*
1402+
* Add the logic to extract BOTH power up and power down sequences
1403+
* from enable/disable link output and only call edp panel control
1404+
* in enable_link_dp and disable_link_dp once.
1405+
*/
1406+
if (dmcu != NULL && dmcu->funcs->unlock_phy)
14071407
dmcu->funcs->unlock_phy(dmcu);
14081408

14091409
dc->link_srv->dp_trace_source_sequence(link, DPCD_SOURCE_SEQ_AFTER_DISABLE_LINK_PHY);

0 commit comments

Comments
 (0)