Skip to content

Commit 5a3d67f

Browse files
Phil Elwellpopcornmix
Phil Elwell
authored andcommitted
brcmfmac: Plug memory leak in brcmf_fill_bss_param
See: #1471 Signed-off-by: Phil Elwell <[email protected]>
1 parent 43e6465 commit 5a3d67f

File tree

1 file changed

+4
-1
lines changed
  • drivers/net/wireless/broadcom/brcm80211/brcmfmac

1 file changed

+4
-1
lines changed

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2413,7 +2413,7 @@ static void brcmf_fill_bss_param(struct brcmf_if *ifp, struct station_info *si)
24132413
WL_BSS_INFO_MAX);
24142414
if (err) {
24152415
brcmf_err("Failed to get bss info (%d)\n", err);
2416-
return;
2416+
goto out_err;
24172417
}
24182418
si->filled |= BIT(NL80211_STA_INFO_BSS_PARAM);
24192419
si->bss_param.beacon_interval = le16_to_cpu(buf->bss_le.beacon_period);
@@ -2425,6 +2425,9 @@ static void brcmf_fill_bss_param(struct brcmf_if *ifp, struct station_info *si)
24252425
si->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_PREAMBLE;
24262426
if (capability & WLAN_CAPABILITY_SHORT_SLOT_TIME)
24272427
si->bss_param.flags |= BSS_PARAM_FLAGS_SHORT_SLOT_TIME;
2428+
2429+
out_err:
2430+
kfree(buf);
24282431
}
24292432

24302433
static s32

0 commit comments

Comments
 (0)