Skip to content

Commit 7866b9f

Browse files
lokendra-singhVudentz
authored andcommitted
Bluetooth: btintel: Send new command for PPAG
Added support for the new command opcode FE0B (HCI Intel PPAG Enable). btmon log: < HCI Command: Intel PPAG Enable (0x3f|0x020b) plen 4 Enable: 0x00000002 > HCI Event: Command Complete (0x0e) plen 4 Intel PPAG Enable (0x3f|0x020b) ncmd 1 Status: Success (0x00) Signed-off-by: Seema Sreemantha <[email protected]> Signed-off-by: Lokendra Singh <[email protected]> Signed-off-by: Luiz Augusto von Dentz <[email protected]>
1 parent 9c08263 commit 7866b9f

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

drivers/bluetooth/btintel.c

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2401,14 +2401,16 @@ static void btintel_set_ppag(struct hci_dev *hdev, struct intel_version_tlv *ver
24012401
{
24022402
struct btintel_ppag ppag;
24032403
struct sk_buff *skb;
2404-
struct btintel_loc_aware_reg ppag_cmd;
2404+
struct hci_ppag_enable_cmd ppag_cmd;
24052405
acpi_handle handle;
24062406

24072407
/* PPAG is not supported if CRF is HrP2, Jfp2, JfP1 */
24082408
switch (ver->cnvr_top & 0xFFF) {
24092409
case 0x504: /* Hrp2 */
24102410
case 0x202: /* Jfp2 */
24112411
case 0x201: /* Jfp1 */
2412+
bt_dev_dbg(hdev, "PPAG not supported for Intel CNVr (0x%3x)",
2413+
ver->cnvr_top & 0xFFF);
24122414
return;
24132415
}
24142416

@@ -2434,24 +2436,29 @@ static void btintel_set_ppag(struct hci_dev *hdev, struct intel_version_tlv *ver
24342436
}
24352437

24362438
if (ppag.domain != 0x12) {
2437-
bt_dev_warn(hdev, "PPAG-BT: domain is not bluetooth");
2439+
bt_dev_dbg(hdev, "PPAG-BT: Bluetooth domain is disabled in ACPI firmware");
24382440
return;
24392441
}
24402442

2441-
/* PPAG mode, BIT0 = 0 Disabled, BIT0 = 1 Enabled */
2442-
if (!(ppag.mode & BIT(0))) {
2443-
bt_dev_dbg(hdev, "PPAG-BT: disabled");
2443+
/* PPAG mode
2444+
* BIT 0 : 0 Disabled in EU
2445+
* 1 Enabled in EU
2446+
* BIT 1 : 0 Disabled in China
2447+
* 1 Enabled in China
2448+
*/
2449+
if ((ppag.mode & 0x01) != BIT(0) && (ppag.mode & 0x02) != BIT(1)) {
2450+
bt_dev_dbg(hdev, "PPAG-BT: EU, China mode are disabled in CB/BIOS");
24442451
return;
24452452
}
24462453

2447-
ppag_cmd.mcc = cpu_to_le32(0);
2448-
ppag_cmd.sel = cpu_to_le32(0); /* 0 - Enable , 1 - Disable, 2 - Testing mode */
2449-
ppag_cmd.delta = cpu_to_le32(0);
2450-
skb = __hci_cmd_sync(hdev, 0xfe19, sizeof(ppag_cmd), &ppag_cmd, HCI_CMD_TIMEOUT);
2454+
ppag_cmd.ppag_enable_flags = cpu_to_le32(ppag.mode);
2455+
2456+
skb = __hci_cmd_sync(hdev, INTEL_OP_PPAG_CMD, sizeof(ppag_cmd), &ppag_cmd, HCI_CMD_TIMEOUT);
24512457
if (IS_ERR(skb)) {
24522458
bt_dev_warn(hdev, "Failed to send PPAG Enable (%ld)", PTR_ERR(skb));
24532459
return;
24542460
}
2461+
bt_dev_info(hdev, "PPAG-BT: Enabled (Mode %d)", ppag.mode);
24552462
kfree_skb(skb);
24562463
}
24572464

drivers/bluetooth/btintel.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,9 @@ struct intel_offload_use_cases {
137137
__u8 preset[8];
138138
} __packed;
139139

140-
struct btintel_loc_aware_reg {
141-
__le32 mcc;
142-
__le32 sel;
143-
__le32 delta;
140+
#define INTEL_OP_PPAG_CMD 0xFE0B
141+
struct hci_ppag_enable_cmd {
142+
__le32 ppag_enable_flags;
144143
} __packed;
145144

146145
#define INTEL_TLV_TYPE_ID 0x01

0 commit comments

Comments
 (0)