Skip to content

Commit d9180e2

Browse files
He Zheacmel
He Zhe
authored andcommitted
perf bench internals inject-build-id: Fix trap divide when collecting just one DSO
'perf bench internals inject-build-id' suffers from the following error when only one DSO is collected. # perf bench internals inject-build-id -v Collected 1 DSOs traps: internals-injec[2305] trap divide error ip:557566ba6394 sp:7ffd4de97fe0 error:0 in perf[557566b2a000+23d000] Build-id injection benchmark Iteration #1 Floating point exception This patch removes the unnecessary minus one from the divisor which also corrects the randomization range. Signed-off-by: He Zhe <[email protected]> Fixes: 0bf02a0 ("perf bench: Add build-id injection benchmark") Cc: Adrian Hunter <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Namhyung Kim <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent b78854e commit d9180e2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/perf/bench/inject-buildid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ static int inject_build_id(struct bench_data *data, u64 *max_rss)
362362
return -1;
363363

364364
for (i = 0; i < nr_mmaps; i++) {
365-
int idx = rand() % (nr_dsos - 1);
365+
int idx = rand() % nr_dsos;
366366
struct bench_dso *dso = &dsos[idx];
367367
u64 timestamp = rand() % 1000000;
368368

0 commit comments

Comments
 (0)