Skip to content

Commit e6e03da

Browse files
Michael Karchertiwai
Michael Karcher
authored andcommitted
ALSA: hda - Remove CD control from model=benq for CX20549
The ID used for detection of the BenQ R55E actually identifies the Quanta TW3 ODM design, which is also used for the Gigabyte W551 laptop series. Schematics on the internet clearly indicate that the "Port C" (analog input connected to record source #4 and mixer input #4) is unconnected. Playing an audio CD through analog playback (using cdplay from cdtools) produces no sound, even with the mixer input labelled "CD" enabled, and the volume control in the CD drive set to maximum. This indicates the connection is really not present. Signed-off-by: Michael Karcher <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
1 parent cbf2d28 commit e6e03da

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

sound/pci/hda/patch_conexant.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -692,9 +692,8 @@ static const struct hda_input_mux cxt5045_capture_source = {
692692
};
693693

694694
static const struct hda_input_mux cxt5045_capture_source_benq = {
695-
.num_items = 5,
695+
.num_items = 4,
696696
.items = {
697-
{ "CD", 0x4 },
698697
{ "Internal Mic", 0x1 },
699698
{ "Mic", 0x2 },
700699
{ "Line", 0x3 },
@@ -819,9 +818,6 @@ static const struct snd_kcontrol_new cxt5045_mixers[] = {
819818
};
820819

821820
static const struct snd_kcontrol_new cxt5045_benq_mixers[] = {
822-
HDA_CODEC_VOLUME("CD Playback Volume", 0x17, 0x4, HDA_INPUT),
823-
HDA_CODEC_MUTE("CD Playback Switch", 0x17, 0x4, HDA_INPUT),
824-
825821
HDA_CODEC_VOLUME("Line Playback Volume", 0x17, 0x3, HDA_INPUT),
826822
HDA_CODEC_MUTE("Line Playback Switch", 0x17, 0x3, HDA_INPUT),
827823

0 commit comments

Comments
 (0)