Skip to content

Commit ecc2fe2

Browse files
Hans Verkuilmchehab
Hans Verkuil
authored andcommitted
[media] cx23885: video instead of vbi register used
The VID_A_GPCNT register is for video, not vbi. Read from the right register and don't write to the video register. Based upon Devin's initial patch made for an older kernel which I cleaned up and rebased. Thanks to Kernel Labs for that work. Signed-off-by: Devin Heitmueller <[email protected]> Signed-off-by: Hans Verkuil <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 6c43a21 commit ecc2fe2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/media/pci/cx23885/cx23885-vbi.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ int cx23885_vbi_irq(struct cx23885_dev *dev, u32 status)
8383
if (status & VID_BC_MSK_VBI_RISCI1) {
8484
dprintk(1, "%s() VID_BC_MSK_VBI_RISCI1\n", __func__);
8585
spin_lock(&dev->slock);
86-
count = cx_read(VID_A_GPCNT);
86+
count = cx_read(VBI_A_GPCNT);
8787
cx23885_video_wakeup(dev, &dev->vbiq, count);
8888
spin_unlock(&dev->slock);
8989
handled++;
@@ -103,7 +103,6 @@ static int cx23885_start_vbi_dma(struct cx23885_dev *dev,
103103
VBI_LINE_LENGTH, buf->risc.dma);
104104

105105
/* reset counter */
106-
cx_write(VID_A_GPCNT_CTL, 3);
107106
cx_write(VID_A_VBI_CTRL, 3);
108107
cx_write(VBI_A_GPCNT_CTL, 3);
109108
q->count = 0;

0 commit comments

Comments
 (0)