Skip to content

Commit f6e23e5

Browse files
akemnadegregkh
authored andcommitted
mmc: omap_hsmmc: fix wakeirq handling on removal
commit 3c398f3 upstream. after unbinding mmc I get things like this: [ 185.294067] mmc1: card 0001 removed [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13 The wakeirq stays in /proc-interrupts rebinding shows this: [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup) [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling That bug seems to be introduced by switching from devm_request_irq() to generic wakeirq handling. So let us cleanup at removal. Signed-off-by: Andreas Kemnade <[email protected]> Fixes: 5b83b22 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq") Cc: [email protected] # v4.2+ Signed-off-by: Ulf Hansson <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 51e8d7d commit f6e23e5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/mmc/host/omap_hsmmc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2194,6 +2194,7 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
21942194
dma_release_channel(host->tx_chan);
21952195
dma_release_channel(host->rx_chan);
21962196

2197+
dev_pm_clear_wake_irq(host->dev);
21972198
pm_runtime_dont_use_autosuspend(host->dev);
21982199
pm_runtime_put_sync(host->dev);
21992200
pm_runtime_disable(host->dev);

0 commit comments

Comments
 (0)