Skip to content

Do we need a specific repo for community-written PIO libraries ? #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjcross opened this issue Jun 20, 2021 · 13 comments
Closed

Do we need a specific repo for community-written PIO libraries ? #168

mjcross opened this issue Jun 20, 2021 · 13 comments
Labels
question Further information is requested

Comments

@mjcross
Copy link

mjcross commented Jun 20, 2021

I saw a few references to 'PIO Library' in the docs, but I don't really see one except for the examples and extras.

Increasingly I should imagine there will be PIO Libraries for specific IO tasks (e.g. I've just written one to transmit NEC IR codes); and it would be nice to have a centralised place to post them.

@lurch
Copy link
Contributor

lurch commented Jun 20, 2021

PRs to https://github.com/raspberrypi/pico-examples (to the develop branch) are more than welcome 🙂 (e.g. raspberrypi/pico-examples#126 )

If you want to include a README.adoc like https://github.com/raspberrypi/pico-examples/tree/master/gpio/hello_7segment then we might also include it the "App Notes" appendix of https://datasheets.raspberrypi.org/pico/raspberry-pi-pico-c-sdk.pdf

@lurch lurch added the question Further information is requested label Jun 20, 2021
@mjcross
Copy link
Author

mjcross commented Jun 20, 2021

OK I'll have a crack at that 👍
In order to make it a bit more suitable for pico-examples I'll see if I can add a receive library too using the other PIO instance, so that people can do a sort of IR loopback test.

@pmarques-dev
Copy link

This is my first contribution to pico-examples and didn't notice the develop branch, so I did the pull request against master. Should I just cancel this pull request and post a new one for develop?

@lurch
Copy link
Contributor

lurch commented Jun 23, 2021

@pmarques-dev There was an SDK release not long ago, so develop is currently in-step with master. So you should just be able to click the "Edit" button at the top of your PR, and change the base branch (or whatever GitHub calls it) to develop 🙂

@pmarques-dev
Copy link

OK, I've just done that now, thank you

@aallan
Copy link
Contributor

aallan commented Jun 23, 2021

If there's a PR in place over on pico-examples I'll close this issue.

@aallan aallan closed this as completed Jun 23, 2021
@lurch
Copy link
Contributor

lurch commented Jun 23, 2021

@aallan There's a PR which @pmarques-dev created, but not yet a PR that @mjcross created (unfortunately there's been a bit of overlap in discussion of the PRs / issues).

@lurch lurch reopened this Jun 23, 2021
@aallan
Copy link
Contributor

aallan commented Jun 23, 2021

Ah gotcha.

@mjcross
Copy link
Author

mjcross commented Jun 23, 2021

@aallan There's a PR which @pmarques-dev created, but not yet a PR that @mjcross created (unfortunately there's been a bit of overlap in discussion of the PRs / issues).

Thanks @lurch - it's coming :-)
I want to add NEC receive before I create the PR; first iteration of the Rx code in testing this afternoon

@mjcross
Copy link
Author

mjcross commented Jun 26, 2021

Update: code is all now working to my satisfaction; I'm just about to fork the develop branch of https://github.com/raspberrypi/pico-examples and start (attempting to) integrate it...

@mjcross
Copy link
Author

mjcross commented Jun 26, 2021

Update: code builds within the source tree; now working on a README.adoc

@lurch
Copy link
Contributor

lurch commented Jun 28, 2021

I'm going to close this issue, now that you've opened raspberrypi/pico-examples#129 🙂

@lurch lurch closed this as completed Jun 28, 2021
@mjcross
Copy link
Author

mjcross commented Jun 28, 2021

Excellent! Thanks @lurch that was a job I meant to do this morning but you beat me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants