Skip to content

Commit 12247d5

Browse files
committed
fix: applied code review suggestions
- fixed incorrect versions of cppwinrt package - fixed typo in installation's docs - changed directory path from MSBuildThisFileDirectory to SolutionDir
1 parent 2131334 commit 12247d5

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

website/docs/Installation.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ react-native link @react-native-async-storage/async-storage
3535

3636
#### Windows
3737

38-
- **React Native Windows > 0.63**
38+
- **React Native Windows >= 0.63**
3939
[CLI autolink feature](https://microsoft.github.io/react-native-windows/docs/native-modules-autolinking) links the module while building the app.
4040

4141
- **React Native Windows <= 0.62**

windows/ReactNativeAsyncStorage/ReactNativeAsyncStorage.vcxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3-
<Import Project="$(SolutionDir)packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(SolutionDir)packages\Microsoft.Windows.CppWinRT.2.0.190730.2\build\native\Microsoft.Windows.CppWinRT.props')" />
3+
<Import Project="$(SolutionDir)packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('$(SolutionDir)packages\Microsoft.Windows.CppWinRT.2.0.200316.3\build\native\Microsoft.Windows.CppWinRT.props')" />
44
<PropertyGroup Label="Globals">
55
<CppWinRTOptimized>true</CppWinRTOptimized>
66
<CppWinRTRootNamespaceAutoMerge>true</CppWinRTRootNamespaceAutoMerge>
@@ -18,7 +18,7 @@
1818
</PropertyGroup>
1919
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2020
<PropertyGroup Label="ReactNativeWindowsProps">
21-
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
21+
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
2222
</PropertyGroup>
2323
<ItemGroup Label="ProjectConfigurations">
2424
<ProjectConfiguration Include="Debug|ARM">
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="Microsoft.Windows.CppWinRT" version="2.0.190730.2" targetFramework="native" />
3+
<package id="Microsoft.Windows.CppWinRT" version="2.0.200316.3" targetFramework="native" />
44
</packages>

windows/ReactNativeAsyncStorage61/ReactNativeAsyncStorage61.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
</PropertyGroup>
1919
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2020
<PropertyGroup Label="ReactNativeWindowsProps">
21-
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
21+
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
2222
</PropertyGroup>
2323
<ItemGroup Label="ProjectConfigurations">
2424
<ProjectConfiguration Include="Debug|ARM">

0 commit comments

Comments
 (0)