chore: GH workflows, turbo and other chores (#1073)

* explicit prettierrc

* turbo

* format test

* pull-request workflow

* update actions

* bump to yarn 4

* build script

Author: krizzu

Diff for: .github/actions/setup-project/action.yml

@@ -0,0 +1,19 @@
+name: Setup project
+description: Install required tools
+inputs:
+  node-version:
+    required: false
+    description: node version to install
+    default: 20.10.0 # is already cached in Ubuntu 22.04 runner
+runs:
+  using: composite
+  steps:
+    - name: Enable corepack
+      shell: bash
+      run: |
+        corepack enable
+        yarn --version
+    - uses: actions/setup-node@v4
+      with:
+        node-version: ${{ inputs.node-version }}
+        cache: "yarn"

Diff for: .github/workflows/ci.yml renamed to .github/workflows/default-storage.yml

@@ -1,58 +1,35 @@
-name: CI
+name: Default storage
 on:
   push:
     branches:
       - main
   pull_request:
 jobs:
-  format:
-    name: Format
+  changes:
+    name: report changed files
     runs-on: ubuntu-latest
+    outputs:
+      changed: ${{ steps.filter.outputs.storage }}
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Set up Node.js
-        uses: actions/[email protected]
-        with:
-          node-version: 18.16.1
-          cache: yarn
-      - name: Install JS dependencies
-        run: yarn
-      - name: Format
-        run: |
-          yarn format
-          git diff --exit-code
-  review:
-    name: Review
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        test-name: [lint, ts]
-        workspace: [default-storage, api]
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Set up Node.js
-        uses: actions/[email protected]
+      - uses: actions/checkout@v4
+      - uses: dorny/paths-filter@v3
+        id: filter
         with:
-          node-version: 18.16.1
-          cache: yarn
-      - name: Install JS dependencies
-        run: yarn
-      - name: Run test ${{ matrix.test-name }}
-        run: yarn test:${{ matrix.test-name }}
-        working-directory: packages/${{ matrix.workspace }}
+          token: ${{ secrets.GH_RELEASE_TOKEN }}
+          filters: |
+            storage:
+              - 'packages/default-storage'
+
   android:
     name: Android
+    needs: changes
+    if: ${{ needs.changes.outputs.changed == 'true' }}
     runs-on: ubuntu-22.04
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
-      - name: Set up Node.js
-        uses: actions/[email protected]
-        with:
-          node-version: 18.16.1
-          cache: yarn
+        uses: actions/checkout@v4
+      - name: Setup project
+        uses: ./.github/actions/setup-project
       - name: Install JS dependencies
         run: |
           yarn
@@ -69,21 +46,20 @@ jobs:
 
   ios:
     name: iOS
+    needs: changes
+    if: ${{ needs.changes.outputs.changed == 'true' }}
     runs-on: macos-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+      - name: Setup project
+        uses: ./.github/actions/setup-project
       - name: Cache /.ccache
         uses: actions/cache@v3
         with:
           path: packages/default-storage/.ccache
           key: ccache-ios-${{ hashFiles('yarn.lock') }}
           restore-keys: ccache-ios-
-      - name: Set up Node.js
-        uses: actions/[email protected]
-        with:
-          node-version: 18.16.1
-          cache: yarn
       - name: Install JS dependencies
         run: |
           yarn
@@ -102,21 +78,20 @@ jobs:
 
   macos:
     name: macOS
+    needs: changes
+    if: ${{ needs.changes.outputs.changed == 'true' }}
     runs-on: macos-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+      - name: Setup project
+        uses: ./.github/actions/setup-project
       - name: Cache /.ccache
         uses: actions/cache@v3
         with:
           path: packages/default-storage/.ccache
           key: ccache-macos-${{ hashFiles('yarn.lock') }}
           restore-keys: ccache-macos-
-      - name: Set up Node.js
-        uses: actions/[email protected]
-        with:
-          node-version: 18.16.1
-          cache: yarn
       - name: Install JS dependencies
         run: |
           yarn
@@ -140,19 +115,18 @@ jobs:
 
   windows:
     name: Windows
+    needs: changes
+    if: ${{ needs.changes.outputs.changed == 'true' }}
     runs-on: windows-2022
     steps:
       - name: Set up MSBuild
         uses: microsoft/[email protected]
       - name: Setup VSTest.console.exe
         uses: darenm/[email protected]
       - name: Checkout
-        uses: actions/checkout@v3
-      - name: Set up Node.js
-        uses: actions/[email protected]
-        with:
-          node-version: 18.16.1
-          cache: yarn
+        uses: actions/checkout@v4
+      - name: Setup project
+        uses: ./.github/actions/setup-project
       - name: Install JS dependencies
         run: |
           yarn
@@ -167,19 +141,16 @@ jobs:
 
   release:
     name: Release
-    needs: [format, review, android, ios, macos, windows]
+    needs: [android, ios, macos, windows]
     if: github.event_name == 'push'
     runs-on: ubuntu-22.04
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
-      - name: Set up Node.js
-        uses: actions/[email protected]
-        with:
-          node-version: 18.16.1
-          cache: yarn
+      - name: Setup project
+        uses: ./.github/actions/setup-project
       - name: Install JS dependencies
         run: |
           yarn

Diff for: .github/workflows/pull-request.yml

@@ -0,0 +1,19 @@
+name: PR review
+on:
+  pull_request:
+jobs:
+  code-quality:
+    name: Code quality
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        test-name: [lint, ts, format]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup project
+        uses: ./.github/actions/setup-project
+      - name: Install dependencies
+        run: yarn
+      - name: test ${{ matrix.test-name }}
+        run: yarn test:${{ matrix.test-name }}

Diff for: .github/workflows/stale.yml

@@ -1,4 +1,4 @@
-name: Mark stale issues and pull requests
+name: Stale issue
 on:
   schedule:
     - cron: "30 1 * * *"

Diff for: .github/workflows/website-deployment.yml

@@ -1,4 +1,4 @@
-name: Website Deployment
+name: Website
 on:
   push:
     branches:
@@ -13,12 +13,9 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
-      - name: Cache/restore dependencies
-        uses: actions/cache@v3
-        with:
-          path: .yarn
-          key: website-${{ hashFiles('yarn.lock') }}
+        uses: actions/checkout@v4
+      - name: Setup project
+        uses: ./.github/actions/setup-project
       - name: Install dependencies
         run: yarn
         working-directory: ./packages/website

Diff for: .gitignore

@@ -2,7 +2,6 @@
 .idea
 .yarn
 .gradle
-!.yarn/releases
 node_modules/
 npm-debug.log
 yarn-error.log
@@ -31,3 +30,4 @@ local.properties
 
 #workspaces
 /packages/*/lib
+.turbo

Diff for: .prettierrc

@@ -0,0 +1,3 @@
+{
+  "trailingComma": "es5"
+}

Diff for: .yarn/releases/yarn-3.4.1.cjs

@@ -1,24 +1,25 @@
+enableGlobalCache: false
 enableTelemetry: false
+nodeLinker: node-modules
+npmRegistryServer: "https://registry.npmjs.org"
 logFilters:
-  - code: YN0007 # X must be built because it never has been before or the last one failed
+  - code: YN0007
     level: discard
-  - code: YN0008 # X must be rebuilt because its dependency tree changed
+  - code: YN0008
     level: discard
-  - code: YN0013 # X can't be found in the cache and will be fetched from the remote registry
+  - code: YN0013
     level: discard
-nodeLinker: node-modules
-npmRegistryServer: "https://registry.npmjs.org"
+
 packageExtensions:
   "@expo/cli@*":
     peerDependencies:
-      "expo-modules-autolinking": "*"
-  "babel-preset-expo@*":
+      expo-modules-autolinking: "*"
+  babel-preset-expo@*:
     peerDependencies:
-      "@babel/core": "^7.0.0-0"
-  "expo@*":
+      "@babel/core": ^7.0.0-0
+  expo-asset@*:
     peerDependencies:
-      "@babel/core": "^7.0.0-0"
-  "expo-asset@*":
+      expo: "*"
+  expo@*:
     peerDependencies:
-      "expo": "*"
-yarnPath: .yarn/releases/yarn-3.4.1.cjs
+      "@babel/core": ^7.0.0-0

Diff for: .yarnrc.yml

@@ -4,16 +4,24 @@
   "workspaces": [
     "packages/*"
   ],
-  "packageManager": "[email protected]",
+  "packageManager": "[email protected]",
+  "engines": {
+    "node": "v20.11.1"
+  },
   "scripts": {
+    "build": "turbo run build",
     "format": "concurrently 'yarn:format:*'",
     "format:c": "clang-format -i $(git ls-files '*.cpp' '*.h' '*.m' '*.mm') --style file:.config/.clang-format",
-    "format:js": "prettier --write --loglevel error $(git ls-files '*.js' '*.json' '*.ts' '*.tsx' '*.yml' 'README.md')"
+    "format:js": "prettier --write $(git ls-files '*.js' '*.json' '*.ts' '*.tsx' '*.yml' 'README.md')",
+    "test:lint": "turbo run test:lint",
+    "test:ts": "turbo run test:ts",
+    "test:format": "prettier --check --loglevel warn $(git ls-files '*.js' '*.json' '*.ts' '*.tsx' '*.yml' 'README.md')"
   },
   "devDependencies": {
     "concurrently": "^8.2.2",
     "eslint": "^8.54.0",
     "prettier": "^2.8.8",
+    "turbo": "^1.12.5",
     "typescript": "^5.3.0"
   },
   "resolutions": {

Diff for: package.json

@@ -17,8 +17,7 @@
     "prepack": "yarn build",
     "build": "bob build",
     "test:lint": "eslint $(git ls-files '*.js' '*.ts' '*.tsx')",
-    "test:ts": "tsc --noEmit",
-    "test:jest": "jest"
+    "test:ts": "tsc --noEmit"
   },
   "keywords": [
     "react-native",
@@ -31,12 +30,9 @@
   "author": "Krzysztof Borowy <[email protected]>",
   "license": "MIT",
   "devDependencies": {
-    "@types/jest": "29.5.4",
     "eslint": "^8.54.0",
-    "jest": "29.5.0",
     "prettier": "^2.8.8",
     "react-native-builder-bob": "0.20.0",
-    "ts-jest": "29.1.1",
     "typescript": "^5.3.0"
   },
   "react-native-builder-bob": {

Diff for: packages/api/jest.config.js

@@ -1,7 +1,4 @@
 {
   "extends": "../../.config/tsconfig.base.json",
-  "compilerOptions": {
-    "types": ["jest"]
-  },
   "include": ["example", "src"]
 }

Diff for: packages/api/package.json

@@ -38,7 +38,8 @@
     "directory": "packages/default-storage-backend"
   },
   "scripts": {
-    "prepare": "bob build",
+    "prepack": "yarn build",
+    "build": "bob build",
     "start": "react-native start",
     "start:android": "react-native run-android",
     "start:ios": "react-native run-ios",

Diff for: packages/api/tsconfig.json

@@ -0,0 +1,13 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "pipeline": {
+    "test:lint": {},
+    "test:ts": {},
+    "build": {
+      "outputs": ["lib/**"]
+    },
+    "async-storage-website#build": {
+      "outputs": ["build/**"]
+    }
+  }
+}