Fix ios build for xcode 12 + use_frameworks!

[stu-dev]

Summary

Fix for issue described in #509

Test Plan

Build a new RN project referencing PR branch

npx react-native init RNAsyncStorage && cd RNAsyncStorage
yarn add https://github.com/stu-dev/async-storage#fix/xcode-12-use-frameworks

• Add use_frameworks! to Podfile (also disable flipper)

npx pod-install
yarn ios

[tido64]

This looks fine to me. I don't know why CircleCI didn't trigger for this PR so I tested this manually on my own machine, from react-native 0.60 through 0.63, and didn't hit any issues.

@krizzu: Any last comments?

[krizzu]

We had PR merged previously to remove React-Core dependency to address other issue. I just want to be sure that this change would not break other people builds. Is there some way to use different dependencies based on usage of use_framework in cocoa?

[tido64]

We had PR merged previously to remove React-Core dependency to address other issue. I just want to be sure that this change would not break other people builds. Is there some way to use different dependencies based on usage of use_framework in cocoa?

Yeah, I didn't use use_framework when testing locally, so I'm not quite sure what the other issue was about.

[stu-dev]

We had PR merged previously to remove React-Core dependency to address other issue. I just want to be sure that this change would not break other people builds. Is there some way to use different dependencies based on usage of use_framework in cocoa?

I mean technically the PR you reference broke the build for me, so may have affected others. I also don't think the issue in question was reproducible? Could have easily been caused by caching issues

Edit: The number of PRs attached to this issue on the main RN repo shows that there is an overwhelming consensus that React-Core is correct

[krizzu]

We had PR merged previously to remove React-Core dependency to address other issue. I just want to be sure that this change would not break other people builds. Is there some way to use different dependencies based on usage of use_framework in cocoa?

I mean technically the PR you reference broke the build for me, so may have affected others. I also don't think the issue in question was reproducible? Could have easily been caused by caching issues

Edit: The number of PRs attached to this issue on the main RN repo shows that there is an overwhelming consensus that React-Core is correct

Looks like React-Core is indeed the correct here - we'll just have to remember that once we do that change, we should instruct whoever comes with the related issue, to delete the pod folder, do pod install and in Xcode clean the project and build it again.

I'll do some testing later today to confirm this works and approve this

[krizzu]

@tido64 @stu-dev
So I just tested locally, I covered scenarios:

• fresh RN app, and AsyncStorage as dependency, works fine.
• used use_frameworks!, disabled flipper and changed dependency to React-Core. Had to clear Pods and build directory through Xcode
• removed use_frameworks!, but kept React-Core

And all of those works just fine. Good to go 👍

[tido64]

Thanks everyone! Merging this.

[krizzu]

🎉 This PR is included in version 1.13.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀