Skip to content

init command has runtime errors that should be unit tests #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grabbou opened this issue Nov 6, 2018 · 0 comments
Closed

init command has runtime errors that should be unit tests #14

grabbou opened this issue Nov 6, 2018 · 0 comments

Comments

@grabbou
Copy link
Member

grabbou commented Nov 6, 2018

There's no need to validate React Native's package.json on client-side. This should be an error before we even publish React Native (or removed at all as it sounds like a fundamental feature of React Native).

Throwing this during runtime has no point.

https://github.com/react-native-community/react-native-cli/blob/a56441021f6455b61f353fcb137d17c86ccc0043/packages/cli/src/commands/init/init.js#L54-L67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants