Skip to content

Commit ab9c486

Browse files
authored
fix: RN Windows Dependency and Example (#267)
* Move react-native-windows back to being a peerDependency @rectified95 added Windows support to datetime-picker a while back. react-native-windows was added as a peer dependency, but this created warnings in cases where react-native-windows wasn't present in the host app. These warnings are currently present for all community modules with Windows support when RNW isn't installed. A [follow-up change a few months ago](feda177) moved react-native-windows from a peerDependency to an optional dependency. This got rid of the warning but also means that: - Every user of datetimepicker is now pulling in react-native-windows by default, even if they don't need it - Due to how it's declared, we now have a transitive peer dependency forcing usage of RN 0.62 instead of RN 0.63 - It will potentially be broken on even react-native-windows 0.62 since we're pulling in multiple RNW versions This change moves the dependency back to a peer dependency, loosens it to support RNW 0.63, and fixes up a couple of devDependencies that were looser than requested by react-native. * Fix Windows Example
1 parent 03ba7a2 commit ab9c486

File tree

3 files changed

+16
-24
lines changed

3 files changed

+16
-24
lines changed

example/App.js

+2
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,12 @@ const ThemedTextInput = (props) => {
4949
const MODE_VALUES = Platform.select({
5050
ios: Object.values(IOS_MODE),
5151
android: Object.values(ANDROID_MODE),
52+
windows: [],
5253
});
5354
const DISPLAY_VALUES = Platform.select({
5455
ios: Object.values(IOS_DISPLAY),
5556
android: Object.values(ANDROID_DISPLAY),
57+
windows: [],
5658
});
5759
const MINUTE_INTERVALS = [1, 2, 3, 4, 5, 6, 10, 12, 15, 20, 30];
5860

package.json

+4-6
Original file line numberDiff line numberDiff line change
@@ -69,22 +69,20 @@
6969
"metro-react-native-babel-preset": "^0.58.0",
7070
"moment": "^2.24.0",
7171
"prettier": "^2.0.5",
72-
"react": "^16.11.0",
72+
"react": "16.11.0",
7373
"react-native": "^0.62.2",
7474
"react-native-windows": "^0.62.0-0",
75-
"react-test-renderer": "^16.11.0",
75+
"react-test-renderer": "16.11.0",
7676
"semantic-release": "^17.1.1"
7777
},
7878
"peerDependencies": {
7979
"react": ">=16.8.3",
80-
"react-native": ">=0.59"
80+
"react-native": ">=0.59",
81+
"react-native-windows": ">=0.62"
8182
},
8283
"dependencies": {
8384
"invariant": "^2.2.4"
8485
},
85-
"optionalDependencies": {
86-
"react-native-windows": "^0.62.0-0"
87-
},
8886
"detox": {
8987
"test-runner": "jest",
9088
"runner-config": "example/e2e/config.json",

yarn.lock

+10-18
Original file line numberDiff line numberDiff line change
@@ -8427,20 +8427,20 @@ react-refresh@^0.4.0:
84278427
resolved "https://registry.yarnpkg.com/react-refresh/-/react-refresh-0.4.3.tgz#966f1750c191672e76e16c2efa569150cc73ab53"
84288428
integrity sha512-Hwln1VNuGl/6bVwnd0Xdn1e84gT/8T9aYNL+HAKDArLCS7LWjwr7StE30IEYbIkx0Vi3vs+coQxe+SQDbGbbpA==
84298429

8430-
react-test-renderer@^16.11.0:
8431-
version "16.13.1"
8432-
resolved "https://registry.yarnpkg.com/react-test-renderer/-/react-test-renderer-16.13.1.tgz#de25ea358d9012606de51e012d9742e7f0deabc1"
8433-
integrity sha512-Sn2VRyOK2YJJldOqoh8Tn/lWQ+ZiKhyZTPtaO0Q6yNj+QDbmRkVFap6pZPy3YQk8DScRDfyqm/KxKYP9gCMRiQ==
8430+
8431+
version "16.11.0"
8432+
resolved "https://registry.yarnpkg.com/react-test-renderer/-/react-test-renderer-16.11.0.tgz#72574566496462c808ac449b0287a4c0a1a7d8f8"
8433+
integrity sha512-nh9gDl8R4ut+ZNNb2EeKO5VMvTKxwzurbSMuGBoKtjpjbg8JK/u3eVPVNi1h1Ue+eYK9oSzJjb+K3lzLxyA4ag==
84348434
dependencies:
84358435
object-assign "^4.1.1"
84368436
prop-types "^15.6.2"
84378437
react-is "^16.8.6"
8438-
scheduler "^0.19.1"
8438+
scheduler "^0.17.0"
84398439

8440-
react@^16.11.0:
8441-
version "16.13.1"
8442-
resolved "https://registry.yarnpkg.com/react/-/react-16.13.1.tgz#2e818822f1a9743122c063d6410d85c1e3afe48e"
8443-
integrity sha512-YMZQQq32xHLX0bz5Mnibv1/LHb3Sqzngu7xstSM+vrkE5Kzr9xE0yMByK5kMoTK30YVJE61WfbxIFFvfeDKT1w==
8440+
8441+
version "16.11.0"
8442+
resolved "https://registry.yarnpkg.com/react/-/react-16.11.0.tgz#d294545fe62299ccee83363599bf904e4a07fdbb"
8443+
integrity sha512-M5Y8yITaLmU0ynd0r1Yvfq98Rmll6q8AxaEe88c8e7LxO8fZ2cNgmFt0aGAS9wzf1Ao32NKXtCl+/tVVtkxq6g==
84448444
dependencies:
84458445
loose-envify "^1.1.0"
84468446
object-assign "^4.1.1"
@@ -8963,22 +8963,14 @@ saxes@^5.0.0:
89638963
dependencies:
89648964
xmlchars "^2.2.0"
89658965

8966-
8966+
[email protected], scheduler@^0.17.0:
89678967
version "0.17.0"
89688968
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.17.0.tgz#7c9c673e4ec781fac853927916d1c426b6f3ddfe"
89698969
integrity sha512-7rro8Io3tnCPuY4la/NuI5F2yfESpnfZyT6TtkXnSWVkcu0BCDJ+8gk5ozUaFaxpIyNuWAPXrH0yFcSi28fnDA==
89708970
dependencies:
89718971
loose-envify "^1.1.0"
89728972
object-assign "^4.1.1"
89738973

8974-
scheduler@^0.19.1:
8975-
version "0.19.1"
8976-
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.19.1.tgz#4f3e2ed2c1a7d65681f4c854fa8c5a1ccb40f196"
8977-
integrity sha512-n/zwRWRYSUj0/3g/otKDRPMh6qv2SYMWNq85IEa8iZyAv8od9zDYpGSnpBEjNgcMNq6Scbu5KfIPxNF72R/2EA==
8978-
dependencies:
8979-
loose-envify "^1.1.0"
8980-
object-assign "^4.1.1"
8981-
89828974
semantic-release@^17.1.1:
89838975
version "17.1.1"
89848976
resolved "https://registry.yarnpkg.com/semantic-release/-/semantic-release-17.1.1.tgz#d9775968e841b2b7c5020559e4481aea8520ca75"

0 commit comments

Comments
 (0)