add Android timezone offset support

[billnbell]

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
iOS	✅ ❌
Android	✅ ❌

Checklist

• I have tested this on a device and a simulator
• I added the documentation in README.md
• I updated the typed files (TS and Flow)
• I added a sample use of the API in the example project (example/App.js)
• I have added automated tests, either in JS or e2e tests, as applicable

[vonovak]

hello, thanks for the PR!

Can you please take a look at the readme and update it? (https://github.com/react-native-datetimepicker/datetimepicker#timezoneoffsetinminutes-optional-ios-only)

Would you be willing to add an end-to-end test for this? They live here: https://github.com/react-native-datetimepicker/datetimepicker/blob/master/example/e2e/detoxTest.spec.js and it would be really nice to have this covered so we know it works the same (and continues to do so) on both platforms, thank you!

[billnbell]

OK made all these changes From: Vojtech Novak <[email protected]> Date: Wednesday, February 10, 2021 at 6:58 AM To: react-native-datetimepicker/datetimepicker <[email protected]> Cc: William Bell <[email protected]>, Author <[email protected]> Subject: Re: [react-native-datetimepicker/datetimepicker] Fix for adding Android timeoffset (#396) @vonovak requested changes on this pull request. hello, thanks for the PR! Can you please take a look at the readme and update it? (https://github.com/react-native-datetimepicker/datetimepicker#timezoneoffsetinminutes-optional-ios-only<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freact-native-datetimepicker%2Fdatetimepicker%23timezoneoffsetinminutes-optional-ios-only&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882642434%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JINgPo3fXBBkXVfbO4JDvEAWD5WyizRPMyApmY6CY%2Bw%3D&reserved=0>) Would you be willing to add an end-to-end test for this? They live here: https://github.com/react-native-datetimepicker/datetimepicker/blob/master/example/e2e/detoxTest.spec.js<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freact-native-datetimepicker%2Fdatetimepicker%2Fblob%2Fmaster%2Fexample%2Fe2e%2FdetoxTest.spec.js&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882652430%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=c86Hn493V3zShKVCKuLxhGTg%2BSbJK8PntPwldzbmX2A%3D&reserved=0> and it would be really nice to have this covered so we know it works the same (and continues to do so) on both platforms, thank you!

________________________________ In android/src/main/java/com/reactcommunity/rndatetimepicker/RNDate.java<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freact-native-datetimepicker%2Fdatetimepicker%2Fpull%2F396%23discussion_r573742870&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882652430%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Zq%2F5HGZcc4Hc9ZwAktVD5ua1zKbnQsSS%2FATvJYjCvYg%3D&reserved=0>:

import android.os.Bundle;

public class RNDate { private Calendar now; public RNDate(Bundle args) { now = Calendar.getInstance(); + if (args != null && args.containsKey("timeZoneOffsetInMinutes")) { can you please extract "timeZoneOffsetInMinutes" into a constant, same as RNConstants.ARG_VALUE?

________________________________ In src/datetimepicker.android.js<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freact-native-datetimepicker%2Fdatetimepicker%2Fpull%2F396%23discussion_r573743789&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882662427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=n38tdD0spW%2FTrFy1cBb5OBEmF0OioZCjQYHOD2dcIhE%3D&reserved=0>:

@@ -109,7 +113,14 @@ export default function RNDateTimePicker(props: AndroidNativeProps) {

break; case TIME_SET_ACTION: - event.nativeEvent.timestamp = date.setHours(hour, minute); + date.setHours(hour, minute); + if (timeZoneOffsetInMinutes !== undefined) { + const offset = + date.getTimezoneOffset() * 60000 + could you please extract 60000 and give it a name? I'm aiming at making the code readability as good as possible for newcomers and it this would help understanding it, thanks

________________________________ In src/types.js<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freact-native-datetimepicker%2Fdatetimepicker%2Fpull%2F396%23discussion_r573744039&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882662427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=CLvCtD4Mgph03QHC0FniftXiqXIH6l32ErqyUpBV1T0%3D&reserved=0>:

@@ -136,6 +136,7 @@ export type AndroidNativeProps = $ReadOnly<{|

*/ display: Display, + timeZoneOffsetInMinutes?: ?number, I'm guessing the TS typings should be updated as well. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freact-native-datetimepicker%2Fdatetimepicker%2Fpull%2F396%23pullrequestreview-587626705&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882672421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=5yZYPpnc1qUiWOT5L9mQK3axwtJrxW9j0u8FrlnSJoE%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGBTSQJESDOBALLVR6HSBOTS6KGG5ANCNFSM4XJ3P3TQ&data=04%7C01%7C%7C1cdc9fc6d6d345e2f3c808d8cdcbe479%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637485622882672421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9cqC6deMqz0sf7ws7q1upld6iu4C87bNImsCXrm%2B4jU%3D&reserved=0>.

[billnbell]

OK done

[billnbell]

what is next step? Ready - ??

[vonovak]

@billnbell thanks for the patience, I will look into this soon :)

[billnbell]

ok ready?

[vonovak]

Thank you!

[vonovak]

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[vonovak]

Hello @billnbell and sorry for taking the time on this one. Would you be interested in becoming a collaborator on the project? 🙂 Thanks!

[billnbell]

What is a Collaborator?

[vonovak]

collaborator / maintainer.. Someone who uses the module (although that is not a condition) and is willing to contribute bugfixes or new features, improve documentation, do code reviews or comment on people's issues 🙂