Skip to content

feat: move module out of RNC npm scope #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2021
Merged

feat: move module out of RNC npm scope #404

merged 2 commits into from
Mar 5, 2021

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Mar 2, 2021 •
edited
Loading

Summary

in accordance with react-native-community/discussions-and-proposals#330 I am moving this module out of the RNC npm scope

Test Plan

test suite passes, builds and runs on simulators

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak requested a review from luancurti March 2, 2021 21:53
@vonovak
Copy link
Member Author

vonovak commented Mar 3, 2021

Fyi when this is merged, the final commit message must contain the BREAKING keyword so we get a major version bump. Thanks @luancurti

luancurti
luancurti approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luancurti luancurti merged commit c618613 into master Mar 5, 2021
@luancurti luancurti deleted the feat/move-out-of-RNC branch March 5, 2021 17:23
vonovak pushed a commit that referenced this pull request Mar 5, 2021
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
7df9f3c 
# [3.1.0](v3.0.9...v3.1.0) (2021-03-05)

### Features

* move module out of RNC npm scope ([#404](#404)) ([c618613](c618613))
vonovak added a commit that referenced this pull request Mar 7, 2021
@vonovak
Revert "feat: move module out of RNC npm scope (#404)"
3e9ad92 
This reverts commit c618613.
vonovak added a commit that referenced this pull request Mar 7, 2021
@vonovak
fix: Revert "feat: move module out of RNC npm scope (#404)" (#405)
4756782 
This reverts commit c618613.
vonovak pushed a commit that referenced this pull request Mar 7, 2021
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
b46ad76 
## [3.1.1](v3.1.0...v3.1.1) (2021-03-07)

### Bug Fixes

* Revert "feat: move module out of RNC npm scope ([#404](#404))" ([#405](#405)) ([4756782](4756782))
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luancurti luancurti luancurti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonovak @luancurti