Skip to content

Revert "feat: move module out of RNC npm scope (#404)" #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2021
Merged

Revert "feat: move module out of RNC npm scope (#404)" #405

merged 1 commit into from
Mar 7, 2021

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Mar 7, 2021 •
edited
Loading

This reverts commit c618613.

Summary

motivation: I was being stupid and didn't check if the npm scope is available

we'll try again when we know more, in the mean time I need to revert to not confuse people

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅ ❌
Android ✅ ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak merged commit 4756782 into master Mar 7, 2021
@vonovak vonovak deleted the fix/revert-npm-move branch March 7, 2021 01:35
vonovak pushed a commit that referenced this pull request Mar 7, 2021
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
b46ad76 
## [3.1.1](v3.1.0...v3.1.1) (2021-03-07)

### Bug Fixes

* Revert "feat: move module out of RNC npm scope ([#404](#404))" ([#405](#405)) ([4756782](4756782))
@vonovak
Copy link
Member Author

vonovak commented Mar 7, 2021

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vonovak