Skip to content

fix: use android resource ids instead of names #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Dec 11, 2021

Summary

this makes the code a little more resilient by not depending in RN core

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak merged commit 717a76f into master Dec 11, 2021
@vonovak vonovak deleted the fix/use-resource-ids branch December 11, 2021 23:18
vonovak pushed a commit that referenced this pull request Dec 11, 2021
## [5.0.1](v5.0.0...v5.0.1) (2021-12-11)

### Bug Fixes

* use android resource ids instead of names ([#541](#541)) ([717a76f](717a76f))
@vonovak
Copy link
Member Author

vonovak commented Dec 11, 2021

🎉 This issue has been resolved in version 5.0.1 🎉

If this package helps you, consider sponsoring us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant