feat: return result of android dialog dismissal #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
pushed a commit
that referenced
this pull request
Jul 25, 2022
## [6.2.2](v6.2.1...v6.2.2) (2022-07-25) ### Bug Fixes * return result of android dialog dismissal to JS ([#636](#636)) ([98335f2](98335f2))
|
🎉 This issue has been resolved in version 6.2.2 🎉 If this package helps you, consider sponsoring us! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the native side, the android
dismisscall returns a promise that the JS side does not return to the call site.This fixes that.
Test Plan
tested locally
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)