-
Notifications
You must be signed in to change notification settings - Fork 204
Is this project still maintained? #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@pvinis It seems like version 1.0.0 isn't published to npm, and there are also more commits since 1.0.0 that would be great if we could get released! There is also a lot of open issues that seems like we could close after cutting a new release, and still a few pull requests that could either be closed, or updated and merged. If you want someone to help maintain this library I would be happy to step up! As it stands right now we are a bit hesitant to depend on this library 😅 Thanks! |
Right, I'm with you! I don't actually have permission to publish. Let's ping @kelset about how to handle this. |
Hey folks 👋 sorry, I've forgot to update here. I've raised this in the Discord and AFAIK we are reaching out to the original developer to get some auths. This should unlock this lib and we'll get a couple maintainers (if I understood the conversation 😅) |
Ongoing :) |
+1 |
It's out people! https://www.npmjs.com/package/@react-native-community/hooks Install with |
Excuse me for the words but I just looked around the hooks and saw so many bad practices in your project (mostly about performance) so I wonder whether you still maintain this project or not.
For example, this hook does resubscribe event every time the component renders. There is a fix here but for maybe some reasons it is merged yet: #38
src/useAppState.ts
This hook creates new
getPhotos
andsaveToCameraRoll
functions every time the hook is called. It would cause the hook consumer component to rerender unexpectedly.src/useCameraRoll.ts
The text was updated successfully, but these errors were encountered: