Skip to content

Add countdown option to iOSMode types #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elsieclark
Copy link
Contributor

Summary

The countdown mode is a valid iOS mode, but the string is not recognized as a valid option by Typescript, and should be added to the type.

To avoid throwing an error, I currently need to use something like mode={'countdown' as any}. This is not the intended flow.

Fixes #28

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

The `countdown` mode is a valid iOS mode, but the string is not recognized as a valid option by Typescript, and should be added to the type.
@vonovak vonovak merged commit 379b03a into react-native-datetimepicker:master Jan 29, 2020
@vonovak
Copy link
Member

vonovak commented Jan 29, 2020

thank you!

@vonovak vonovak mentioned this pull request Jan 29, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong props type definition about mode or wrong documentation
2 participants