Detox tests added #6
Conversation
| compileSdkVersion = 28 | ||
| targetSdkVersion = 28 |
There was a problem hiding this comment.
why did this need to be downgraded?
There was a problem hiding this comment.
This is what fixed the issue for running the detox tests in android-release. When using targetSdkVersion = 28 the app was getting installed but the tests weren't running.
|
|
||
| // Set the default timeout | ||
| jest.setTimeout(120000); | ||
| jasmine.getEnv().addReporter(adapter); |
There was a problem hiding this comment.
where is jasmine coming from here? Does detox provide that on global by default?
There was a problem hiding this comment.
jest is actually using jasmine so it's coming from jest/adapter
example/App.js
Outdated
| @@ -34,21 +34,40 @@ export default class App extends Component<Props> { | |||
| this.show('time'); | |||
| } | |||
|
|
|||
| mmddyyyy = (date) => { | |||
| var yyyy = date.getUTCFullYear(); | |||
| var mm = date.getUTCMonth() < 9 ? '0' + (date.getUTCMonth() + 1) : (date.getUTCMonth() + 1); // getUTCMonth() is zero-based | |||
There was a problem hiding this comment.
This can probably be cleaned up a bit if the optional 0 is prepended after the actual, also would this display 010 if the returned month is 9? Also would prefer regular functions here as part of the class
There was a problem hiding this comment.
As this is an exampe app, can't we just use data-fn's to clean this up a little bit?
There was a problem hiding this comment.
I have ended up using moment. date-fns was giving me problems for timezones and it seems that there is no way of defining a timezone for the format function.
package-lock.json
Outdated
| "resolved": "https://artifactory.secureserver.net/artifactory/api/npm/node-virt/core-js/-/core-js-3.1.2.tgz", | ||
| "integrity": "sha1-JUmiz7PKGl2FHJ94OOiygs7y87o=", | ||
| "version": "3.1.3", | ||
| "resolved": "https://artifactory.secureserver.net/artifactory/api/npm/node-virt/core-js/-/core-js-3.1.3.tgz", |
example/App.js
Outdated
| @@ -34,21 +34,40 @@ export default class App extends Component<Props> { | |||
| this.show('time'); | |||
| } | |||
|
|
|||
| mmddyyyy = (date) => { | |||
| var yyyy = date.getUTCFullYear(); | |||
| var mm = date.getUTCMonth() < 9 ? '0' + (date.getUTCMonth() + 1) : (date.getUTCMonth() + 1); // getUTCMonth() is zero-based | |||
There was a problem hiding this comment.
As this is an exampe app, can't we just use data-fn's to clean this up a little bit?
| @@ -1,13 +0,0 @@ | |||
| module.exports = function (api) { | |||
There was a problem hiding this comment.
Does the normal example still work after you deleted all of this?
There was a problem hiding this comment.
Yep, you just need to do npm run start and then npm run start:ios or npm run start:android. All the dependencies are now pointing to the root node_modules.
| dateTimeText: { | ||
| fontSize: 16, | ||
| fontWeight: 'normal', | ||
| }, |
There was a problem hiding this comment.
Remove extra , -- but that also means that a linter didn't run, so can you run the linter over these files?
There was a problem hiding this comment.
I have included the example folder for linting and it is requiring that ,. I guess that this is how it is defined in @react-native-community.
There was a problem hiding this comment.
This is part of the react-native-community eslint config, they like their comma's :)
Summary
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)