100% test coverage

Author: Archmonger

Diff for: docs/Dockerfile

@@ -33,6 +33,6 @@ RUN sphinx-build -v -W -b html source build
 # Define Entrypoint
 # -----------------
 ENV PORT=5000
-ENV REACTPY_DEBUG_MODE=1
+ENV REACTPY_DEBUG=1
 ENV REACTPY_CHECK_VDOM_SPEC=0
 CMD ["python", "main.py"]

Diff for: pyproject.toml

@@ -117,9 +117,6 @@ xfail_strict = true
 asyncio_mode = "auto"
 log_cli_level = "INFO"
 
-[tool.hatch.envs.hatch-test.env-vars]
-REACTPY_DEBUG_MODE = "1"
-
 #######################################
 # >>> Hatch Documentation Scripts <<< #
 #######################################
@@ -241,7 +238,7 @@ omit = [
 ]
 
 [tool.coverage.report]
-fail_under = 98
+fail_under = 100
 show_missing = true
 skip_covered = true
 sort = "Name"

Diff for: src/reactpy/asgi/utils.py

@@ -17,17 +17,21 @@
 def import_dotted_path(dotted_path: str) -> Any:
     """Imports a dotted path and returns the callable."""
     if "." not in dotted_path:
-        raise ValueError(f"{dotted_path!r} is not a valid dotted path.")
+        raise ValueError(f'"{dotted_path}" is not a valid dotted path.')
 
     module_name, component_name = dotted_path.rsplit(".", 1)
 
     try:
         module = import_module(module_name)
     except ImportError as error:
-        msg = f"Failed to import {module_name!r} while loading {component_name!r}"
-        raise RuntimeError(msg) from error
+        msg = f'ReactPy failed to import "{module_name}"'
+        raise ImportError(msg) from error
 
-    return getattr(module, component_name)
+    try:
+        return getattr(module, component_name)
+    except AttributeError as error:
+        msg = f'ReactPy failed to import "{component_name}" from "{module_name}"'
+        raise AttributeError(msg) from error
 
 
 def import_components(dotted_paths: Iterable[str]) -> dict[str, Any]:
@@ -111,4 +115,4 @@ def process_settings(settings: ReactPyConfig) -> None:
         if config_object:
             config_object.set_current(settings[setting])  # type: ignore
         else:
-            raise ValueError(f"Unknown ReactPy setting {setting!r}.")
+            raise ValueError(f'Unknown ReactPy setting "{setting}".')

Diff for: src/reactpy/core/hooks.py

@@ -185,7 +185,7 @@ def use_debug_value(
     """Log debug information when the given message changes.
 
     .. note::
-        This hook only logs if :data:`~reactpy.config.REACTPY_DEBUG_MODE` is active.
+        This hook only logs if :data:`~reactpy.config.REACTPY_DEBUG` is active.
 
     Unlike other hooks, a message is considered to have changed if the old and new
     values are ``!=``. Because this comparison is performed on every render of the

Diff for: src/reactpy/core/serve.py

@@ -66,7 +66,7 @@ async def _single_outgoing_loop(
                 msg = (
                     "Failed to send update. More info may be available "
                     "if you enabling debug mode by setting "
-                    "`reactpy.config.REACTPY_DEBUG_MODE.current = True`."
+                    "`reactpy.config.REACTPY_DEBUG.current = True`."
                 )
                 logger.error(msg)
             raise

Diff for: src/reactpy/testing/backend.py

@@ -11,7 +11,8 @@
 import uvicorn
 from asgiref import typing as asgi_types
 
-from reactpy.asgi.standalone import ReactPy, ReactPyMiddleware
+from reactpy.asgi.middleware import ReactPyMiddleware
+from reactpy.asgi.standalone import ReactPy
 from reactpy.config import REACTPY_TESTS_DEFAULT_TIMEOUT
 from reactpy.core.component import component
 from reactpy.core.hooks import use_callback, use_effect, use_state

Diff for: src/reactpy/testing/display.py

@@ -67,7 +67,7 @@ async def __aenter__(self) -> DisplayFixture:
 
         self.page.set_default_timeout(REACTPY_TESTS_DEFAULT_TIMEOUT.current * 1000)
 
-        if not hasattr(self, "backend"):
+        if not hasattr(self, "backend"):  # pragma: no cover
             self.backend = BackendFixture()
             await es.enter_async_context(self.backend)
 

Diff for: tests/conftest.py

@@ -10,6 +10,7 @@
 
 from reactpy.config import (
     REACTPY_ASYNC_RENDERING,
+    REACTPY_DEBUG,
     REACTPY_TESTS_DEFAULT_TIMEOUT,
 )
 from reactpy.testing import (
@@ -19,7 +20,8 @@
     clear_reactpy_web_modules_dir,
 )
 
-REACTPY_ASYNC_RENDERING.current = True
+REACTPY_ASYNC_RENDERING.set_current(True)
+REACTPY_DEBUG.set_current(True)
 GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS", "False") in {
     "y",
     "yes",

Diff for: tests/test_asgi/test_middleware.py

@@ -1,3 +1,4 @@
+# ruff: noqa: S701
 from pathlib import Path
 
 import pytest

Diff for: tests/test_asgi/test_utils.py

@@ -0,0 +1,38 @@
+import pytest
+
+from reactpy import config
+from reactpy.asgi import utils
+
+
+def test_invalid_dotted_path():
+    with pytest.raises(ValueError, match='"abc" is not a valid dotted path.'):
+        utils.import_dotted_path("abc")
+
+
+def test_invalid_component():
+    with pytest.raises(
+        AttributeError, match='ReactPy failed to import "foobar" from "reactpy"'
+    ):
+        utils.import_dotted_path("reactpy.foobar")
+
+
+def test_invalid_module():
+    with pytest.raises(ImportError, match='ReactPy failed to import "foo"'):
+        utils.import_dotted_path("foo.bar")
+
+
+def test_invalid_vdom_head():
+    with pytest.raises(ValueError, match="Invalid head element!*"):
+        utils.vdom_head_to_html({"tagName": "invalid"})
+
+
+def test_process_settings():
+    utils.process_settings({"async_rendering": False})
+    assert config.REACTPY_ASYNC_RENDERING.current is False
+    utils.process_settings({"async_rendering": True})
+    assert config.REACTPY_ASYNC_RENDERING.current is True
+
+
+def test_invalid_setting():
+    with pytest.raises(ValueError, match='Unknown ReactPy setting "foobar".'):
+        utils.process_settings({"foobar": True})

Diff for: tests/test_client.py

@@ -1,12 +1,10 @@
 import asyncio
-from contextlib import AsyncExitStack
 from pathlib import Path
 
 from playwright.async_api import Page
 
 import reactpy
 from reactpy.testing import BackendFixture, DisplayFixture, poll
-from reactpy.testing.utils import find_available_port
 from tests.tooling.common import DEFAULT_TYPE_DELAY
 from tests.tooling.hooks import use_counter
 

Diff for: tests/test_config.py

@@ -23,7 +23,7 @@ def reset_options():
             opt.current = val
 
 
-def test_reactpy_debug_mode_toggle():
+def test_reactpy_debug_toggle():
     # just check that nothing breaks
     config.REACTPY_DEBUG.current = True
     config.REACTPY_DEBUG.current = False

Diff for: tests/test_web/test_utils.py

@@ -5,6 +5,7 @@
 
 from reactpy.testing import assert_reactpy_did_log
 from reactpy.web.utils import (
+    _resolve_relative_url,
     module_name_suffix,
     resolve_module_exports_from_file,
     resolve_module_exports_from_source,
@@ -150,3 +151,15 @@ def test_log_on_unknown_export_type():
         assert resolve_module_exports_from_source(
             "export something unknown;", exclude_default=False
         ) == (set(), set())
+
+
+def test_resolve_relative_url():
+    assert (
+        _resolve_relative_url("https://some.url", "path/to/another.js")
+        == "path/to/another.js"
+    )
+    assert (
+        _resolve_relative_url("https://some.url", "/path/to/another.js")
+        == "https://some.url/path/to/another.js"
+    )
+    assert _resolve_relative_url("/some/path", "to/another.js") == "to/another.js"