no need to use eval to do a dynamic import in JS

rmorshea · rmorshea · commit a9e4f296c23f · 2020-10-05T21:07:29.000-07:00
diff --git a/idom/client/app/core_modules/layout.js b/idom/client/app/core_modules/layout.js
@@ -170,7 +170,7 @@ function useLazyModule(source) {
 }
 
 function dynamicImport(source) {
-  return eval(`import('${source}')`).then(
+  return import(source).then(
     (pkg) => (pkg.default ? pkg.default : pkg),
     (error) => {
       if (!error.stack) {

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ function useLazyModule(source) {`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`function dynamicImport(source) {`
`173`		- return eval(`import('${source}')`).then(
	`173`	`+ return import(source).then(`
`174`	`174`	`(pkg) => (pkg.default ? pkg.default : pkg),`
`175`	`175`	`(error) => {`
`176`	`176`	`if (!error.stack) {`