Skip to content

Document the importSource key in the VDOM spec #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rmorshea opened this issue Feb 26, 2021 · 1 comment · May be fixed by #1052
Open

Document the importSource key in the VDOM spec #304

rmorshea opened this issue Feb 26, 2021 · 1 comment · May be fixed by #1052
Labels
priority-3-low May be resolved one any timeline. type-docs About changes and updates to documentation

Comments

@rmorshea
Copy link
Collaborator

This is not documented yet, and it needs to be. The importSource key comes from this data structure: https://github.com/idom-team/idom/blob/230794350d6a80457f15bf3d5e47f2794bbaef5c/idom/core/vdom.py#L10-L12
@rmorshea rmorshea added the type-docs About changes and updates to documentation label Feb 26, 2021
@rmorshea rmorshea self-assigned this Feb 26, 2021
@rmorshea
Copy link
Collaborator Author

This is partially resolved by: #308

We should still explain what the source and fallback are.

@rmorshea rmorshea added the priority-3-low May be resolved one any timeline. label Jan 13, 2022
@rmorshea rmorshea added this to the 2.0 milestone Jan 13, 2022
@rmorshea rmorshea removed their assignment Jul 1, 2022
@Archmonger Archmonger removed this from the Luxury Features milestone Jan 29, 2023
@Archmonger Archmonger linked a pull request Jun 14, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline. type-docs About changes and updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite the docs reactive-python/reactpy
2 participants
@rmorshea @Archmonger