Skip to content

Add iFrame to idom.html #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Dec 9, 2021 · 1 comment · Fixed by #554
Closed

Add iFrame to idom.html #542

Archmonger opened this issue Dec 9, 2021 · 1 comment · Fixed by #554

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Dec 9, 2021 •
edited
Loading

Current Situation

Currently, iframes are missing from our standard VDOM types. Right now users are forced to manually create iframes via make_vdom_constructor.

Proposed Changes

Add iframe to idom.html

Implementation Details

iframe = make_vdom_constructor("iframe")
@Archmonger Archmonger added the flag-triage Not prioritized. label Dec 9, 2021
@rmorshea
Copy link
Collaborator

rmorshea commented Dec 9, 2021 •
edited
Loading

For now the best option is just to use vdom("iframe", ...) unless you want a dedicated function for that.

@rmorshea rmorshea added enhancement and removed flag-triage Not prioritized. labels Dec 9, 2021
@rmorshea rmorshea mentioned this issue Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add more standard html elements reactive-python/reactpy
2 participants
@rmorshea @Archmonger