Skip to content

Deprecate module_from_template #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Oct 19, 2022 Discussed in #821 · 1 comment
Closed

Deprecate module_from_template #822

Archmonger opened this issue Oct 19, 2022 Discussed in #821 · 1 comment
Labels
priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Milestone
1.0.0

Comments

@Archmonger
Copy link
Contributor

Discussed in #821

Originally posted by Archmonger October 18, 2022
While the ability to load JavaScript modules from NPM on the fly is clever, it technologically isn't possible to do properly.

That is due to ReactJS version mismatches, which frequently pop up when using this API.

For the health of this framework, I would recommend we deprecate module_from_template and double-down on JavaScript Components API docs to supplement this.
@Archmonger Archmonger added priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior labels Oct 19, 2022
@Archmonger Archmonger added this to the 1.0 milestone Oct 19, 2022
@rmorshea
Copy link
Collaborator

rmorshea commented Nov 30, 2022 •
edited
Loading

Closed by: 8f3785b (accidentally pushed to main)

@Archmonger Archmonger mentioned this issue Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger