Skip to content

Commit 9795144

Browse files
committed
resolve feedback
2 parents d735f25 + b86fe5c commit 9795144

File tree

113 files changed

+4120
-1998
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

113 files changed

+4120
-1998
lines changed

.circleci/config.yml

+3
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,6 @@ jobs:
1818
- run:
1919
name: Check Prettier, ESLint, Flow
2020
command: yarn ci-check
21+
- run:
22+
name: Test Textlint
23+
command: yarn test:textlint

.github/PULL_REQUEST_TEMPLATE.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ If your PR references an existing issue, please add the issue number below
1414

1515
## Progress
1616

17-
- [ ] 번역 초안 작성(Draft translation)
18-
- [ ] [공통 스타일 가이드 확인 (Check the common style guide)](link)
19-
- [ ] [용어 확인 (Check the term)](link)
17+
- [ ] 번역 초안 작성 (Draft translation)
18+
- [ ] [공통 스타일 가이드 확인 (Check the common style guide)](https://github.com/reactjs/ko.reactjs.org/blob/master/UNIVERSAL-STYLE-GUIDE.md)
19+
- [ ] [모범사례 확인 (Check best practices)](https://github.com/reactjs/ko.reactjs.org/wiki/Best-practices-for-translation)
20+
- [ ] [용어 확인 (Check the term)](https://github.com/reactjs/ko.reactjs.org/wiki/Translate-Glossary)
2021
- [ ] [맞춤법 검사 (Spelling check)](http://speller.cs.pusan.ac.kr/)
2122
- [ ] 리뷰 반영 (Resolve reviews)

.textlintrc.js

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
module.exports = {
2+
filters: {
3+
comments: true,
4+
},
5+
formatterName: 'stylish',
6+
};

README.md

+41-41
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,70 @@
11
# reactjs.org
22

3-
This repo contains the source code and documentation powering [reactjs.org](https://reactjs.org/).
3+
이 저장소는 [reactjs.org](https://reactjs.org/)의 소스 코드와 개발 문서를 포함하고 있습니다.
44

5-
## Getting started
5+
## 시작하기
66

7-
### Prerequisites
7+
### 사전 준비
88

99
1. Git
10-
1. Node: any 8.x version starting with 8.4.0 or greater
11-
1. Yarn: See [Yarn website for installation instructions](https://yarnpkg.com/lang/en/docs/install/)
12-
1. A fork of the repo (for any contributions)
13-
1. A clone of the [reactjs.org repo](https://github.com/reactjs/reactjs.org) on your local machine
10+
1. Node: 8.4.0 이상으로 시작하는 모든 8.x 버전
11+
1. Yarn: [Yarn website for installation instructions](https://yarnpkg.com/lang/en/docs/install/) 참고
12+
1. 포크한 개인 저장소
13+
1. 로컬에 클론(Clone) 한 [reactjs.org repo](https://github.com/reactjs/reactjs.org) 개인 저장소
1414

15-
### Installation
15+
### 설치
1616

17-
1. `cd reactjs.org` to go into the project root
18-
1. `yarn` to install the website's npm dependencies
17+
1. `cd reactjs.org`를 실행하여 프로젝트 경로로 이동합니다.
18+
1. `yarn`을 이용하여 npm 의존성 모듈들을 설치합니다.
1919

20-
### Running locally
20+
### 개발 서버 실행하기
2121

22-
1. `yarn dev` to start the hot-reloading development server (powered by [Gatsby](https://www.gatsbyjs.org))
23-
1. `open http://localhost:8000` to open the site in your favorite browser
22+
1. `yarn dev` 명령어를 사용하여 hot-reloading 개발 서버를 시작합니다. (powered by [Gatsby](https://www.gatsbyjs.org))
23+
1. `open http://localhost:8000` 명령어를 사용하여 선호하는 브라우저로 접속하세요.
2424

25-
## Contributing
25+
## 기여방법
2626

27-
### Guidelines
27+
### 가이드라인
2828

29-
The documentation is divided into several sections with a different tone and purpose. If you plan to write more than a few sentences, you might find it helpful to get familiar with the [contributing guidelines](https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md#guidelines-for-text) for the appropriate sections.
29+
이 문서는 목적이 다른 여러 섹션으로 나뉘게 됩니다. 문장을 추가할 계획이라면, 적절한 섹션에 대한 [가이드라인](https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md#guidelines-for-text)을 숙지하는 것이 도움이 될 것입니다.
3030

31-
### Create a branch
31+
### 브랜치(branch) 만들기
3232

33-
1. `git checkout master` from any folder in your local `reactjs.org` repository
34-
1. `git pull origin master` to ensure you have the latest main code
35-
1. `git checkout -b the-name-of-my-branch` (replacing `the-name-of-my-branch` with a suitable name) to create a branch
33+
1. `reactjs.org` 로컬 저장소에서 `git checkout master`를 실행합니다.
34+
1. `git pull origin master`를 실행하여 최신 원본 코드를 보장할 수 있습니다.
35+
1. `git checkout -b the-name-of-my-branch` (`the-name-of-my-branch` 를 적절한 이름으로 교체)를 실행하여 브랜치를 만듭니다.
3636

37-
### Make the change
37+
### 수정하기
3838

39-
1. Follow the "Running locally" instructions
40-
1. Save the files and check in the browser
41-
1. Changes to React components in `src` will hot-reload
42-
1. Changes to markdown files in `content` will hot-reload
43-
1. If working with plugins, you may need to remove the `.cache` directory and restart the server
39+
1. "개발 서버 실행하기" 부분을 따릅니다.
40+
1. 파일을 저장하고 브라우저에서 확인합니다.
41+
1.`src`안에 있는 React 컴포넌트가 수정될 경우 hot-reload가 적용됩니다.
42+
1. `content`안에 있는 마크다운 파일이 수정될 경우 hot-reload가 적용됩니다.
43+
1. 플러그인을 사용하는 경우, `.cache` 디렉토리를 제거한 후 서버를 재시작해야 합니다.
4444

45-
### Test the change
45+
### 수정사항 체크하기
4646

47-
1. If possible, test any visual changes in all latest versions of common browsers, on both desktop and mobile.
48-
1. Run `yarn check-all` from the project root. (This will run Prettier, ESLint, and Flow.)
47+
1. 가능하다면, 변경한 부분에 대해서 많이 사용하는 브라우저의 최신 버전에서 시각적으로 제대로 적용되었는지 확인해주세요. (데스크탑과 모바일 모두)
48+
1. 프로젝트 루트에서 `yarn check-all`를 실행합니다. (이 명령어는 Prettier, ESLint, 그리고 Flow를 실행합니다.)
4949

50-
### Push it
50+
### Push 하기
5151

52-
1. `git add -A && git commit -m "My message"` (replacing `My message` with a commit message, such as `Fixed header logo on Android`) to stage and commit your changes
52+
1. `git add -A && git commit -m "My message"` (`My message` 부분을 `Fixed header logo on Android` 같은 커밋 메시지로 교체)를 실행하여 변경한 파일들을 commit 해주세요.
5353
1. `git push my-fork-name the-name-of-my-branch`
54-
1. Go to the [reactjs.org repo](https://github.com/reactjs/reactjs.org) and you should see recently pushed branches.
55-
1. Follow GitHub's instructions.
56-
1. If possible, include screenshots of visual changes. A Netlify build will also be automatically created once you make your PR so other people can see your change.
54+
1. [reactjs.org repo](https://github.com/reactjs/reactjs.org)에서 최근에 푸시된 브랜치를 볼 수 있습니다.
55+
1. Github 지침을 따라주세요.
56+
1. 가능하다면 시각적으로 변화된 부분의 스크린샷을 첨부해주세요. PR을 만들고 다른사람들이 수정사항을 볼 수 있게되면, Netlify가 자동적으로 빌드할 것입니다.
5757

58-
## Translation
58+
## 변역
5959

60-
If you are interested in translating `reactjs.org`, please see the current translation efforts at [isreacttranslatedyet.com](https://www.isreacttranslatedyet.com/).
60+
`reactjs.org` 번역에 흥미가 있다면, [isreacttranslatedyet.com](https://www.isreacttranslatedyet.com/)에서 현재 번역이 얼마나 진행되었는지 확인해주세요.
6161

6262

63-
If your language does not have a translation and you would like to create one, please follow the instructions at [reactjs.org Translations](https://github.com/reactjs/reactjs.org-translation#translating-reactjsorg).
63+
번역하려는 언어가 아직 진행되지 않았다면, 해당 언어에 대해 새롭게 만들 수 있습니다. [reactjs.org Translations](https://github.com/reactjs/reactjs.org-translation#translating-reactjsorg)를 참고해주세요.
6464

65-
## Troubleshooting
65+
## 문제 해결하기
6666

67-
- `yarn reset` to clear the local cache
67+
- `yarn reset` 명령어를 사용하여 로컬 캐시를 초기화합니다.
6868

69-
## License
70-
Content submitted to [reactjs.org](https://reactjs.org/) is CC-BY-4.0 licensed, as found in the [LICENSE-DOCS.md](https://github.com/open-source-explorer/reactjs.org/blob/master/LICENSE-DOCS.md) file.
69+
## 저작권
70+
위 내용에 대한 저작권은 [reactjs.org](https://reactjs.org/)가 가지고 있으며, [LICENSE-DOCS.md](https://github.com/open-source-explorer/reactjs.org/blob/master/LICENSE-DOCS.md)에서 볼 수 있는 CC-BY-4.0 라이센스를 따릅니다.

UNIVERSAL-STYLE-GUIDE.md

+97
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
# 공통 스타일 가이드
2+
3+
이 문서는 **모든** 언어에 적용돼야 할 규칙을 설명합니다.
4+
5+
## 제목 아이디
6+
7+
모든 제목에는 다음과 같이 아이디가 명시적으로 설정되어 있습니다.
8+
9+
```md
10+
## Try React {#try-react}
11+
```
12+
13+
**아이디는 번역하면 안 됩니다!** 이 아이디는 탐색을 위해 사용되므로 번역하면 아래처럼 외부에서 문서가 참조될 때 링크가 깨질 수 있습니다.
14+
15+
```md
16+
자세한 내용은 [시작 부분](/getting-started#try-react)을 참조해주세요.
17+
```
18+
19+
✅ 권장
20+
21+
```md
22+
## React 시도해보기 {#try-react}
23+
```
24+
25+
❌ 금지:
26+
27+
```md
28+
## React 시도해보기 {#react-시도해보기}
29+
```
30+
31+
이는 위에 있는 링크를 깨지게 만듭니다.
32+
33+
## 코드에 있는 문자
34+
35+
주석을 제외한 모든 코드는 번역하지 않고 그대로 놔둬 주세요. 선택적으로 문자열에 있는 텍스트를 수정할 수 있지만, 코드를 참조하는 문자열은 번역하지 않도록 주의해주세요.
36+
37+
예시는 다음과 같습니다.
38+
```js
39+
// Example
40+
const element = <h1>Hello, world</h1>;
41+
ReactDOM.render(element, document.getElementById('root'));
42+
```
43+
44+
✅ 권장
45+
46+
```js
47+
// 예시
48+
const element = <h1>Hello, world</h1>;
49+
ReactDOM.render(element, document.getElementById('root'));
50+
```
51+
52+
✅ 허용:
53+
54+
```js
55+
// 예시
56+
const element = <h1>안녕 세상</h1>;
57+
ReactDOM.render(element, document.getElementById('root'));
58+
```
59+
60+
❌ 금지:
61+
62+
```js
63+
// 예시
64+
const element = <h1>안녕 세상</h1>;
65+
// "root"는 HTML 엘리먼트의 아이디를 의미합니다.
66+
// 번역하지 마세요.
67+
ReactDOM.render(element, document.getElementById('뿌리'));
68+
```
69+
70+
❌ 절대 금지:
71+
72+
```js
73+
// 예시
74+
const 요소 = <h1>안녕 세상</h1>;
75+
ReactDOM.그리다(요소, 문서.아이디로부터_엘리먼트_가져오기('뿌리'));
76+
```
77+
78+
## 외부 링크
79+
80+
외부 링크가 [MDN]이나 [Wikipedia]같은 참고 문헌의 문서에 연결되어 있고 해당 문서가 자국어로 잘 번역되어 있다면 번역 문서를 링크하는 것도 고려해보세요.
81+
82+
[MDN]: https://developer.mozilla.org/en-US/
83+
[Wikipedia]: https://en.wikipedia.org/wiki/Main_Page
84+
85+
예시는 다음과 같습니다.
86+
87+
```md
88+
React elements are [immutable](https://en.wikipedia.org/wiki/Immutable_object).
89+
```
90+
91+
✅ 허용:
92+
93+
```md
94+
React 엘리먼트는 [불변객체](https://ko.wikipedia.org/wiki/불변객체)입니다.
95+
```
96+
97+
외부 링크를 대체할 만한 자국어 자료가 없다면 (Stack Overflow, YouTube 비디오 등) 영어 링크를 사용해주세요.

content/authors.yml

+3
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ sophiebits:
7373
steveluscher:
7474
name: Steven Luscher
7575
url: https://twitter.com/steveluscher
76+
tesseralis:
77+
name: Nat Alison
78+
url: https://twitter.com/tesseralis
7679
timer:
7780
name: Joe Haddad
7881
url: https://twitter.com/timer150

content/blog/2014-09-24-testing-flux-applications.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ The first steps toward working with Jest are as follows:
1717

1818
1. Get the module dependencies for the application installed by running `npm install`.
1919
2. Create a directory `__tests__/` with a test file, in this case TodoStore-test.js
20-
3. Run `npm install jest-cli save-dev`
20+
3. Run `npm install jest-cli --save-dev`
2121
4. Add the following to your package.json
2222

2323
```javascript

content/blog/2018-10-01-create-react-app-v2.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Here's a short summary of what's new in this release:
2525
* 🃏 We updated to [Jest 23](https://jestjs.io/blog/2018/05/29/jest-23-blazing-fast-delightful-testing.html), which includes an [interactive mode](https://jestjs.io/blog/2018/05/29/jest-23-blazing-fast-delightful-testing#interactive-snapshot-mode) for reviewing snapshots.
2626
* 💄 We added [PostCSS](https://preset-env.cssdb.org/features#stage-3) so you can use new CSS features in old browsers.
2727
* 💎 You can use [Apollo](https://github.com/leoasis/graphql-tag.macro#usage), [Relay Modern](https://github.com/facebook/relay/pull/2171#issuecomment-411459604), [MDX](https://github.com/facebook/create-react-app/issues/5149#issuecomment-425396995), and other third-party [Babel Macros](https://babeljs.io/blog/2017/09/11/zero-config-with-babel-macros) transforms.
28-
* 🌠 You can now [import an SVG as a React component](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#adding-svgs), and use it in JSX.
28+
* 🌠 You can now [import an SVG as a React component](https://facebook.github.io/create-react-app/docs/adding-images-fonts-and-files#adding-svgs), and use it in JSX.
2929
* 🐈 You can try the experimental [Yarn Plug'n'Play mode](https://github.com/yarnpkg/rfcs/pull/101) that removes `node_modules`.
3030
* 🕸 You can now [plug your own proxy implementation](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#configuring-the-proxy-manually) in development to match your backend API.
3131
* 🚀 You can now use [packages written for latest Node versions](https://github.com/sindresorhus/ama/issues/446#issuecomment-281014491) without breaking the build.

content/blog/2018-11-27-react-16-roadmap.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ function Example() {
8787
}
8888
```
8989

90-
Hooks [introduction](/docs/hooks-intro.html) and [overview](/docs/hooks-overview.html) are good places to start. Watch [these talks](https://www.youtube.com/watch?v=V-QO-KO90iQ) for a video introduction and a deep dive. The [FAQ](/docs/hooks-faq.html) should answer most of your further questions. To learn more about the motivation behind Hooks, you can read [this article](https://medium.com/@dan_abramov/making-sense-of-react-hooks-fdbde8803889). Some of the rationale for the API design of Hooks is explained in [this RFC thread reply](https://github.com/reactjs/rfcs/pull/68#issuecomment-439314884).
90+
Hooks [introduction](/docs/hooks-intro.html) and [Hook 개요](/docs/hooks-overview.html) are good places to start. Watch [these talks](https://www.youtube.com/watch?v=V-QO-KO90iQ) for a video introduction and a deep dive. The [FAQ](/docs/hooks-faq.html) should answer most of your further questions. To learn more about the motivation behind Hooks, you can read [this article](https://medium.com/@dan_abramov/making-sense-of-react-hooks-fdbde8803889). Some of the rationale for the API design of Hooks is explained in [this RFC thread reply](https://github.com/reactjs/rfcs/pull/68#issuecomment-439314884).
9191

9292
We have been dogfooding Hooks at Facebook since September. We don't expect major bugs in the implementation. Hooks are only available in the 16.7 alpha versions of React. Some of their API is expected to change in the final version (see the end of [this comment](https://github.com/reactjs/rfcs/pull/68#issuecomment-439314884) for details). It is possible that the minor release with Hooks might not be React 16.7.
9393

content/blog/2019-02-06-react-v16.8.0.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Hooks let you use state and other React features without writing a class. You ca
1212
If you've never heard of Hooks before, you might find these resources interesting:
1313

1414
* [Introducing Hooks](/docs/hooks-intro.html) explains why we're adding Hooks to React.
15-
* [Hooks at a Glance](/docs/hooks-overview.html) is a fast-paced overview of the built-in Hooks.
15+
* [Hook 개요](/docs/hooks-overview.html) is a fast-paced overview of the built-in Hooks.
1616
* [Building Your Own Hooks](/docs/hooks-custom.html) demonstrates code reuse with custom Hooks.
1717
* [Making Sense of React Hooks](https://medium.com/@dan_abramov/making-sense-of-react-hooks-fdbde8803889) explores the new possibilities unlocked by Hooks.
1818
* [useHooks.com](https://usehooks.com/) showcases community-maintained Hooks recipes and demos.
@@ -140,10 +140,10 @@ Assuming you already have ESLint installed, run:
140140

141141
```sh
142142
# npm
143-
npm install eslint-plugin-react-hooks@next --save-dev
143+
npm install eslint-plugin-react-hooks --save-dev
144144

145145
# yarn
146-
yarn add eslint-plugin-react-hooks@next --dev
146+
yarn add eslint-plugin-react-hooks --dev
147147
```
148148

149149
Then add it to your ESLint configuration:

0 commit comments

Comments
 (0)