Skip to content

Commit 2941373

Browse files
committed
Revert Bundle Renderer test to before #792
Add pry-byebug for ease of debugging. Update the locally used react_ujs to 2.5.0
1 parent 07199eb commit 2941373

File tree

5 files changed

+16
-2
lines changed

5 files changed

+16
-2
lines changed

.pryrc

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
if defined?(PryByebug)
2+
Pry.commands.alias_command 's', 'step'
3+
Pry.commands.alias_command 'n', 'next'
4+
Pry.commands.alias_command 'f', 'finish'
5+
Pry.commands.alias_command 'c', 'continue'
6+
end

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
"webpack": "^2.3.3"
1515
},
1616
"dependencies": {
17-
"react_ujs": "^2.4.4"
17+
"react_ujs": "^2.5.0"
1818
}
1919
}

react-rails.gemspec

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ Gem::Specification.new do |s|
2828
s.add_development_dependency 'selenium-webdriver'
2929
s.add_development_dependency 'test-unit', '~> 2.5'
3030
s.add_development_dependency 'rails', '>= 3.2'
31+
s.add_development_dependency 'pry-byebug'
3132

3233
s.add_dependency 'connection_pool'
3334
s.add_dependency 'execjs'

test/react/server_rendering/bundle_renderer_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class BundleRendererTest < ActiveSupport::TestCase
7070

7171
if WebpackerHelpers.available?
7272
# require() failed:
73-
assert_match(/TypeError: Cannot read property 'toLowerCase' of undefined/, err.to_s)
73+
assert_match(/Invariant Violation:/, err.to_s)
7474
else
7575
# eval() failed:
7676
assert_match(/ReferenceError/, err.to_s)

yarn.lock

+7
Original file line numberDiff line numberDiff line change
@@ -1624,6 +1624,13 @@ react_ujs@^2.4.4:
16241624
resolved "https://registry.yarnpkg.com/react_ujs/-/react_ujs-2.4.4.tgz#49bac535d24024a96b0a35d7514d18188aea42bc"
16251625
integrity sha512-RON6mgV+I3s6KkmvxTQi+WGuoLbhZ+TzRat06EE/RHFvzU+Na1Eom6XnesQeOP7WCrTZGOdcZEPP0P7QrJrHfg==
16261626

1627+
react_ujs@^2.5.0:
1628+
version "2.5.0"
1629+
resolved "https://registry.yarnpkg.com/react_ujs/-/react_ujs-2.5.0.tgz#b8481818233f54aee2cbee0328baf6eaea290824"
1630+
integrity sha512-uRtlv3ITYv6BGHYO3Z4pS1K2JJtIT2Sz345g/bCbMdwraZZ0BLyq4SnESIkiDmg7SX3bJchb2OmQUSwPjbXB3A==
1631+
dependencies:
1632+
react_ujs "^2.4.4"
1633+
16271634
read-pkg-up@^1.0.1:
16281635
version "1.0.1"
16291636
resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-1.0.1.tgz#9d63c13276c065918d57f002a57f40a1b643fb02"

0 commit comments

Comments
 (0)