Skip to content

Key up / down arrow -> option to have default behaviour #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nsethu opened this issue Apr 23, 2020 · 2 comments · Fixed by #368
Closed

Key up / down arrow -> option to have default behaviour #325

nsethu opened this issue Apr 23, 2020 · 2 comments · Fixed by #368
Labels
released

Comments

@nsethu
Copy link

nsethu commented Apr 23, 2020

For keyboard events - up and down arrow, the library prevent default behaviour. Is it possible to have an option in API to not prevent default behaviour. This will give us ability to scroll up / down the page with up / down arrow even with focus on tabs.
@maumont maumont mentioned this issue Jan 27, 2021
Merged
@maumont
Copy link

maumont commented Jan 27, 2021 •
edited
Loading

Hey @nsethu I've created a PR for this feature #368, I hope the maintainers take a look.

@danez danez closed this as completed Feb 6, 2021
@danez
Copy link
Collaborator

danez commented Feb 6, 2021

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@danez danez added the released label Feb 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New prop to disable up/down arrow keys for changing tabs maumont/react-tabs
3 participants
@danez @maumont @nsethu