Skip to content

Allow iterable instead of array for parallel(), series() and waterfall() #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
clue opened this issue May 17, 2022 · 1 comment
Closed

Allow iterable instead of array for parallel(), series() and waterfall() #41

clue opened this issue May 17, 2022 · 1 comment
Labels
easy pick Good for newcomers help wanted Extra attention is needed new feature New feature or request
Milestone
v3.0.0

Comments

@clue
Copy link
Member

clue commented May 17, 2022

We should support accepting an iterable instead of only an array for parallel(), series() and waterfall(). The iterable pseudo type is available as of PHP 7.1, so we can take advantage of this for our Async v3 and Async v4 (see also #11 and #14). It supports passing an array just like now, but also accepts Iterators and Generators.

I'm not currently working on this, but figured it makes sense to report here in order to track this feature request. In case anybody feels like picking this up, any input and PRs would be much appreciated 👍 (I've also filed the same suggestion for Promise v3 in reactphp/promise#221)
@clue clue added new feature New feature or request easy pick Good for newcomers help wanted Extra attention is needed labels May 17, 2022
@clue clue added this to the v3.0.0 milestone May 17, 2022
This was referenced Jun 12, 2022
Merged
Merged
@clue
Copy link
Member Author

clue commented Jun 14, 2022

Closed via #45 (v3) and #49 (v4).

@clue clue closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy pick Good for newcomers help wanted Extra attention is needed new feature New feature or request
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@clue