Skip to content

Commit c0c889f

Browse files
committed
fixed tests for HHVM, fixes #24
1 parent 913f150 commit c0c889f

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

.travis.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ php:
77
- 7.0
88
- hhvm
99

10-
matrix:
11-
allow_failures:
12-
- php: hhvm
13-
fast_finish: true
14-
1510
install: ./travis-init.sh
1611

1712
script:

tests/AbstractLoopTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public function runShouldReturnWhenNoMoreFds()
176176

177177
$this->writeToStream($input, "foo\n");
178178

179-
$this->assertRunFasterThan(0.005);
179+
$this->assertRunFasterThan(0.015);
180180
}
181181

182182
/** @test */
@@ -194,7 +194,7 @@ public function stopShouldStopRunningLoop()
194194
$this->assertRunFasterThan(0.005);
195195
}
196196

197-
public function testStopShouldPreventRunFromBlocking()
197+
public function testStopShouldPreventRunFromBlocking($timeLimit = 0.005)
198198
{
199199
$this->loop->addTimer(
200200
1,
@@ -209,7 +209,7 @@ function () {
209209
}
210210
);
211211

212-
$this->assertRunFasterThan(0.005);
212+
$this->assertRunFasterThan($timeLimit);
213213
}
214214

215215
public function testIgnoreRemovedCallback()

tests/StreamSelectLoopTest.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,17 @@ public function testStreamSelectTimeoutEmulation()
3737
$this->assertGreaterThan(0.04, $interval);
3838
}
3939

40+
public function testStopShouldPreventRunFromBlocking($timeLimit = 0.005)
41+
{
42+
if (defined('HHVM_VERSION')) {
43+
// HHVM is a bit slow, so give it more time
44+
parent::testStopShouldPreventRunFromBlocking(0.5);
45+
} else {
46+
parent::testStopShouldPreventRunFromBlocking($timeLimit);
47+
}
48+
}
49+
50+
4051
public function signalProvider()
4152
{
4253
return [

0 commit comments

Comments
 (0)