Skip to content

Allow multiple IO callbacks or throw #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kelunik opened this issue Mar 25, 2017 · 1 comment · Fixed by #110
Closed

Allow multiple IO callbacks or throw #87

kelunik opened this issue Mar 25, 2017 · 1 comment · Fixed by #110

Comments

@kelunik
Copy link
Contributor

kelunik commented Mar 25, 2017

Currently, multiple IO callbacks are ignored, only the first one will work. #86 fixes this to be consistent, but silently ignoring should be changed to either throw exceptions or call all handlers and not ignore them.

@clue
Copy link
Member

clue commented Oct 10, 2017

I agree that adding multiple listeners to the same resource makes little sense and should not happen in a real world program 👍

Throwing an exception in this case would be the obvious choice, does anybody feel like filing a PR? :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants