do not reconcile older storageconsumer unless resources are processed

a separate controller will process older storageconsumer owned resources
and until then storageconsumer controller should not proceed with
reconcililation.

Signed-off-by: Leela Venkaiah G <[email protected]>

Author: leelavg

controllers/storageconsumer/storageconsumer_controller.go

@@ -32,6 +32,7 @@ import (
 	"github.com/red-hat-storage/ocs-operator/v4/controllers/defaults"
 	"github.com/red-hat-storage/ocs-operator/v4/controllers/util"
 
+	"github.com/blang/semver/v4"
 	"github.com/go-logr/logr"
 	nbv1 "github.com/noobaa/noobaa-operator/v5/pkg/apis/noobaa/v1alpha1"
 	rookCephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
@@ -161,6 +162,19 @@ func (r *StorageConsumerReconciler) reconcileEnabledPhases() (reconcile.Result,
 			return reconcile.Result{}, err
 		}
 
+		if storageCluster.Spec.AllowRemoteStorageConsumers {
+			clientOperatorVersion, err := semver.Parse(r.storageConsumer.Status.Client.OperatorVersion)
+			if err != nil {
+				return reconcile.Result{}, fmt.Errorf("malformed ClientOperatorVersion: %v", err)
+			}
+			consumerProcessed, exist := r.storageConsumer.GetAnnotations()[util.StorageConsumer418ProcessedAnnotationKey]
+			if clientOperatorVersion.Major == 4 &&
+				clientOperatorVersion.Minor == 18 &&
+				(!exist || consumerProcessed == util.StorageConsumer418ProcessedAnnotationPending) {
+				return reconcile.Result{}, nil
+			}
+		}
+
 		availableServices, err := util.GetAvailableServices(r.ctx, r.Client, storageCluster)
 		if err != nil {
 			return reconcile.Result{}, err
@@ -756,7 +770,12 @@ func (r *StorageConsumerReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	)
 
 	return ctrl.NewControllerManagedBy(mgr).
-		For(&ocsv1alpha1.StorageConsumer{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
+		For(&ocsv1alpha1.StorageConsumer{}, builder.WithPredicates(
+			predicate.Or(
+				predicate.GenerationChangedPredicate{},
+				predicate.AnnotationChangedPredicate{},
+			),
+		)).
 		Owns(&nbv1.NooBaaAccount{}).
 		Owns(&corev1.ConfigMap{}, builder.MatchEveryOwner).
 		Owns(