Skip to content

Commit c0af721

Browse files
committed
fix: dont show actions for selected items when there's no selection (#812)
Signed-off-by: Andre Dietisheim <[email protected]>
1 parent d90a78d commit c0af721

File tree

4 files changed

+18
-3
lines changed

4 files changed

+18
-3
lines changed

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/actions/SetAsCurrentClusterAction.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import com.redhat.devtools.intellij.kubernetes.telemetry.TelemetryService
1919
import com.redhat.devtools.intellij.kubernetes.telemetry.TelemetryService.NAME_PREFIX_CONTEXT
2020
import javax.swing.tree.TreePath
2121

22-
class SetAsCurrentClusterAction: StructureTreeAction(IContext::class.java) {
22+
class SetAsCurrentClusterAction: StructureTreeAction(false, IContext::class.java) {
2323

2424
override fun actionPerformed(event: AnActionEvent?, path: TreePath?, selectedNode: Any?) {
2525
val context: IContext = selectedNode?.getElement() ?: return
@@ -44,7 +44,7 @@ class SetAsCurrentClusterAction: StructureTreeAction(IContext::class.java) {
4444
}
4545

4646
override fun isVisible(selected: Array<out Any>?): Boolean {
47-
return selected?.size == 1
48-
&& isVisible(selected[0])
47+
return !selected.isNullOrEmpty()
48+
&& super.isVisible(selected)
4949
}
5050
}

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/actions/SetCurrentNamespaceAction.kt

+5
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,11 @@ class SetCurrentNamespaceAction : StructureTreeAction(false) {
8383
}
8484
}
8585

86+
override fun isVisible(selected: Array<out Any>?): Boolean {
87+
return !selected.isNullOrEmpty()
88+
&& super.isVisible(selected)
89+
}
90+
8691
override fun isVisible(selected: Any?): Boolean {
8792
return selected?.getElement<NamespacesFolder>() != null
8893
}

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/actions/SetCurrentProjectAction.kt

+5
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,11 @@ class SetCurrentProjectAction : StructureTreeAction(false) {
7979
}
8080
}
8181

82+
override fun isVisible(selected: Array<out Any>?): Boolean {
83+
return !selected.isNullOrEmpty()
84+
&& super.isVisible(selected)
85+
}
86+
8287
override fun isVisible(selected: Any?): Boolean {
8388
return selected?.getElement<ProjectsFolder>() != null
8489
}

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/actions/UseResourceAction.kt

+5
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ import io.fabric8.kubernetes.api.model.HasMetadata
1515

1616
abstract class UseResourceAction<N: HasMetadata>(filter: Class<N>) : StructureTreeAction(false, filter) {
1717

18+
override fun isVisible(selected: Array<out Any>?): Boolean {
19+
return !selected.isNullOrEmpty()
20+
&& super.isVisible(selected)
21+
}
22+
1823
override fun isVisible(selected: Any?): Boolean {
1924
if (!super.isVisible(selected)) {
2025
return false

0 commit comments

Comments
 (0)