Skip to content

Commit c84158e

Browse files
committedJul 23, 2024·
fix: provide unauthorized error msg if ex is unauthorized (#771)
Signed-off-by: Andre Dietisheim <[email protected]>
1 parent d56d8c5 commit c84158e

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
 

‎src/main/kotlin/com/redhat/devtools/intellij/kubernetes/editor/ClusterResource.kt

+7-5
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,13 @@ open class ClusterResource protected constructor(
112112
context.get(initialResource)
113113
} catch (e: RuntimeException) {
114114
val message =
115-
if (e is KubernetesClientException
116-
&& e.isUnsupported()
117-
) {
118-
// api discovery error
119-
e.status.message
115+
if (e is KubernetesClientException) {
116+
when {
117+
// api discovery error
118+
e.isUnsupported() -> e.status.message
119+
e.isUnauthorized() -> "Unauthorized. Verify username and password, refresh token, etc."
120+
else -> e.message
121+
}
120122
} else {
121123
"Could not retrieve ${initialResource.kind} ${initialResource.metadata?.name ?: ""}" +
122124
" in version ${initialResource.apiVersion} from server"

‎src/test/kotlin/com/redhat/devtools/intellij/kubernetes/editor/ClusterResourceTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class ClusterResourceTest {
9898
fun `#pull(true) should throw exception that happens when operator#get throws`() {
9999
// given
100100
whenever(context.get(any()))
101-
.doThrow(KubernetesClientException("forbidden", 401, null))
101+
.doThrow(KubernetesClientException("forbidden", 401, StatusBuilder().withMessage("Unauthorized").build()))
102102
// when
103103
cluster.pull(true)
104104
}

0 commit comments

Comments
 (0)
Please sign in to comment.