Skip to content

Commit f531a86

Browse files
committed
fix: report refreshing all context instead of null (#839)
Signed-off-by: Andre Dietisheim <[email protected]>
1 parent 482f1df commit f531a86

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/main/kotlin/com/redhat/devtools/intellij/kubernetes/actions/RefreshAction.kt

+8-9
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import com.redhat.devtools.intellij.common.actions.StructureTreeAction
1717
import com.redhat.devtools.intellij.kubernetes.model.context.IActiveContext
1818
import com.redhat.devtools.intellij.kubernetes.telemetry.TelemetryService
1919
import com.redhat.devtools.intellij.kubernetes.telemetry.TelemetryService.sendTelemetry
20+
import com.redhat.devtools.intellij.kubernetes.tree.TreeStructure
2021
import com.redhat.devtools.intellij.kubernetes.tree.util.getResourceKind
2122
import javax.swing.tree.TreePath
2223

@@ -25,7 +26,7 @@ class RefreshAction : StructureTreeAction(IActiveContext::class.java) {
2526
override fun actionPerformed(event: AnActionEvent?, path: TreePath?, selectedNode: Any?) {
2627
val descriptor = selectedNode?.getDescriptor()
2728
run(
28-
"Refreshing $selectedNode...", true,
29+
"Refreshing ${refreshedResourceLabel(descriptor)}...", true,
2930
Progressive {
3031
val telemetry = TelemetryService.instance.action(
3132
"refresh ${
@@ -34,7 +35,7 @@ class RefreshAction : StructureTreeAction(IActiveContext::class.java) {
3435
} else {
3536
"all contexts"
3637
}
37-
} "
38+
}"
3839
)
3940
try {
4041
if (descriptor != null) {
@@ -46,15 +47,13 @@ class RefreshAction : StructureTreeAction(IActiveContext::class.java) {
4647
}
4748
} catch (e: Exception) {
4849
logger<RefreshAction>().warn(
49-
"Could not refresh ${
50-
if (descriptor != null) {
51-
"$descriptor resources"
52-
} else {
53-
"all contexts."
54-
}
55-
}", e
50+
"Could not refresh ${refreshedResourceLabel(descriptor)}", e
5651
)
5752
}
5853
})
5954
}
55+
56+
private fun refreshedResourceLabel(descriptor: TreeStructure.Descriptor<*>?): String {
57+
return descriptor?.toString() ?: "all contexts"
58+
}
6059
}

0 commit comments

Comments
 (0)