Review

Author: feloy

pkg/dev/common/run.go

@@ -30,7 +30,7 @@ func Run(
 
 	pod, err := platformClient.GetPodUsingComponentName(componentName)
 	if err != nil {
-		return fmt.Errorf("unable to get pod for component %s: %w. Please check the command odo dev is running", componentName, err)
+		return fmt.Errorf("unable to get pod for component %s: %w. Please check the command 'odo dev' is running", componentName, err)
 	}
 
 	handler := component.NewRunHandler(

pkg/dev/podmandev/run.go

@@ -11,7 +11,7 @@ func (o *DevClient) Run(
 	ctx context.Context,
 	commandName string,
 ) error {
-	klog.V(4).Infof("running command %q on cluster", commandName)
+	klog.V(4).Infof("running command %q on podman", commandName)
 	return common.Run(
 		ctx,
 		commandName,

pkg/libdevfile/libdevfile.go

@@ -66,8 +66,7 @@ func ExecuteCommandByNameAndKind(ctx context.Context, devfileObj parser.DevfileO
 	return executeCommand(ctx, devfileObj, cmd, handler)
 }
 
-// ExecuteCommandByNameAndKind executes the specified command cmdName of the given kind in the Devfile.
-// If cmdName is empty, it executes the default command for the given kind or returns an error if there is no default command.
+// ExecuteCommandByName executes the specified command cmdName in the Devfile.
 // If ignoreCommandNotFound is true, nothing is executed if the command is not found and no error is returned.
 func ExecuteCommandByName(ctx context.Context, devfileObj parser.DevfileObj, cmdName string, handler Handler, ignoreCommandNotFound bool) error {
 	commands, err := devfileObj.Data.GetCommands(

pkg/odo/cli/run/run.go

@@ -68,7 +68,10 @@ func (o *RunOptions) Validate(ctx context.Context) error {
 	commands, err := devfileObj.Data.GetCommands(common.DevfileOptions{
 		FilterByName: o.commandName,
 	})
-	if err != nil || len(commands) != 1 {
+	if err != nil {
+		return err
+	}
+	if len(commands) != 1 {
 		return errors.NewNoCommandNameInDevfileError(o.commandName)
 	}
 

tests/examples/source/devfiles/nodejs/devfile-for-run.yaml

@@ -17,6 +17,12 @@ components:
         - name: "3000-tcp"
           targetPort: 3000
       mountSources: true
+  - name: other-container
+    container:
+      image: registry.access.redhat.com/ubi8/nodejs-12:1-36
+      command: ["tail"]
+      args: ["-f", "/dev/null"]
+      memoryLimit: 1024Mi
   - name: config
     kubernetes:
       inlined: |
@@ -67,6 +73,11 @@ commands:
       component: runtime
       commandLine: touch /tmp/new-file
       workingDir: ${PROJECTS_ROOT}
+  - id: create-file-in-other-container
+    exec:
+      component: other-container
+      commandLine: touch /tmp/new-file-in-other-container
+      workingDir: ${PROJECTS_ROOT}
   - id: deploy-config
     apply:
       component: config

tests/integration/cmd_run_test.go

@@ -73,7 +73,7 @@ var _ = Describe("odo run command tests", func() {
 		It("should fail if odo dev is not running", func() {
 			output := helper.Cmd("odo", "run", "build").ShouldFail().Err()
 			Expect(output).To(ContainSubstring(`unable to get pod for component`))
-			Expect(output).To(ContainSubstring(`Please check the command odo dev is running`))
+			Expect(output).To(ContainSubstring(`Please check the command 'odo dev' is running`))
 		})
 
 		for _, podman := range []bool{false, true} {
@@ -108,6 +108,13 @@ var _ = Describe("odo run command tests", func() {
 						component.Exec("runtime", []string{"ls", "/tmp/new-file"}, pointer.Bool(true))
 					})
 
+					By("executing an exec command in another container", func() {
+						output := helper.Cmd("odo", "run", "create-file-in-other-container", "--platform", platform).ShouldPass().Out()
+						Expect(output).To(ContainSubstring("Executing command in container (command: create-file-in-other-container)"))
+						component := helper.NewComponent(cmpName, "app", labels.ComponentDevMode, commonVar.Project, commonVar.CliRunner)
+						component.Exec("other-container", []string{"ls", "/tmp/new-file-in-other-container"}, pointer.Bool(true))
+					})
+
 					if !podman {
 						By("executing apply command on Kubernetes component", func() {
 							output := helper.Cmd("odo", "run", "deploy-config", "--platform", platform).ShouldPass().Out()