Skip to content

Commit 780b1f2

Browse files
committed
Address PR comment and add Route
1 parent 22fee19 commit 780b1f2

File tree

2 files changed

+29
-8
lines changed

2 files changed

+29
-8
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ The `templates` folder contains OpenShift templates. Some of these will be shipp
5555
oc create -f <template.json>
5656
```
5757

58-
**dotnet**
58+
**dotnet-example**
5959

60-
The dotnet template can be used to create a new .NET Core service in OpenShift. It provides parameters for all the environment
60+
The dotnet-example template can be used to create a new .NET Core service in OpenShift. It provides parameters for all the environment
6161
variables of the s2i-dotnetcore builder. It also includes a liveness and a readiness probe.

templates/dotnet.json templates/dotnet-example.json

+27-6
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
"kind": "Template",
33
"apiVersion": "v1",
44
"metadata": {
5-
"name": "dotnet",
5+
"name": "dotnet-example",
66
"annotations": {
77
"openshift.io/display-name": ".NET Core",
8-
"description": "Template for creating .NET Core service",
8+
"description": "An example .NET Core application.",
99
"tags": "quickstart,dotnet,.net",
1010
"iconClass": "icon-dotnet",
1111
"template.openshift.io/provider-display-name": "Red Hat, Inc.",
@@ -14,6 +14,20 @@
1414
}
1515
},
1616
"objects": [
17+
{
18+
"kind": "Route",
19+
"apiVersion": "v1",
20+
"metadata": {
21+
"name": "${NAME}"
22+
},
23+
"spec": {
24+
"host": "${APPLICATION_DOMAIN}",
25+
"to": {
26+
"kind": "Service",
27+
"name": "${NAME}"
28+
}
29+
}
30+
},
1731
{
1832
"kind": "Service",
1933
"apiVersion": "v1",
@@ -213,7 +227,7 @@
213227
"displayName": "Name",
214228
"description": "The name assigned to all of the frontend objects defined in this template.",
215229
"required": true,
216-
"value": "dotnet-service"
230+
"value": "dotnet-example"
217231
},
218232
{
219233
"name": "MEMORY_LIMIT",
@@ -246,12 +260,19 @@
246260
{
247261
"name": "SOURCE_REPOSITORY_REF",
248262
"displayName": "Git Reference",
249-
"description": "Set this to a branch name, tag or other ref of your repository if you are not using the default branch."
263+
"description": "Set this to a branch name, tag or other ref of your repository if you are not using the default branch.",
264+
"value": "dotnetcore-1.0"
250265
},
251266
{
252267
"name": "CONTEXT_DIR",
253268
"displayName": "Context Directory",
254-
"description": "Set this to the relative path to your project if it is not in the root of your repository."
269+
"description": "Set this to use a subdirectory of the source code repository"
270+
},
271+
{
272+
"name": "APPLICATION_DOMAIN",
273+
"displayName": "Application Hostname",
274+
"description": "The exposed hostname that will route to the Node.js service, if left blank a value will be defaulted.",
275+
"value": ""
255276
},
256277
{
257278
"name": "GITHUB_WEBHOOK_SECRET",
@@ -295,4 +316,4 @@
295316
"value": "Release"
296317
}
297318
]
298-
}
319+
}

0 commit comments

Comments
 (0)