Set context error when using invalid source value

When we encounter an invalid source value in an annotation, we need to
properly set the pipeline into an error state to not continue binding
operations.  This reports an error back to the user that their
sourceValue isn't correct.

Signed-off-by: Andy Sadler <[email protected]>

Author: sadlerap

pkg/reconcile/pipeline/handler/collect/impl.go

@@ -18,13 +18,15 @@ import (
 )
 
 var DataNotMap = errors.New("Returned data are not a map, skip collecting")
+var ErrorValueNotFound = errors.New("Value not found in map")
 
 const (
 	ErrorReadingServicesReason   = "ErrorReadingServices"
 	ErrorReadingCRD              = "ErrorReadingCRD"
 	ErrorReadingDescriptorReason = "ErrorReadingDescriptor"
 	ErrorReadingBindingReason    = "ErrorReadingBinding"
 	ErrorReadingSecret           = "ErrorReadingSecret"
+	ValueNotFound                = "ValueNotFound"
 )
 
 func PreFlight(ctx pipeline.Context) {
@@ -254,8 +256,10 @@ func collectItems(prefix string, ctx pipeline.Context, service pipeline.Service,
 			} else {
 				condition := v1alpha1.Conditions().NotCollectionReady().
 					Msg(fmt.Sprintf("Value for key %v_%v not found", prefix+k.String(), n.String())).
-					Reason("ValueNotFound").Build()
+					Reason(ValueNotFound).Build()
 				ctx.SetCondition(condition)
+				ctx.Error(ErrorValueNotFound)
+				ctx.StopProcessing()
 				return
 			}
 		}

pkg/reconcile/pipeline/handler/collect/impl_test.go

@@ -1084,12 +1084,13 @@ var _ = Describe("Issue 943", func() {
 			crd.EXPECT().Resource().Return(&unstructured.Unstructured{})
 			service.EXPECT().CustomResourceDefinition().Return(crd, nil)
 
-			// TODO: msg must be rephrased.
 			ctx.EXPECT().SetCondition(
 				v1alpha1.Conditions().NotCollectionReady().
-					Reason("ValueNotFound").
+					Reason(collect.ValueNotFound).
 					Msg("Value for key java-maven_port_foo not found").
 					Build())
+			ctx.EXPECT().Error(collect.ErrorValueNotFound)
+			ctx.EXPECT().StopProcessing()
 
 			collect.BindingDefinitions(ctx)
 			collect.BindingItems(ctx)