Run 'odo push' for component in terminal

Fix #416.

Author: dgolovin

src/extension.ts

@@ -37,7 +37,7 @@ export function activate(context: vscode.ExtensionContext) {
         vscode.commands.registerCommand('openshift.component.describe', (context) => executeSync(Component.describe, context)),
         vscode.commands.registerCommand('openshift.component.create', (context) => execute(Component.create, context)),
         vscode.commands.registerCommand('openshift.component.delete.palette', (context) => execute(Component.del, context)),
-        vscode.commands.registerCommand('openshift.component.push', (context) => execute(Component.push, context)),
+        vscode.commands.registerCommand('openshift.component.push', (context) => executeSync(Component.push, context)),
         vscode.commands.registerCommand('openshift.component.watch', (context) => executeSync(Component.watch, context)),
         vscode.commands.registerCommand('openshift.component.log', (context) => executeSync(Component.log, context)),
         vscode.commands.registerCommand('openshift.component.followLog', (context) => executeSync(Component.followLog, context)),

src/openshift/component.ts

@@ -87,17 +87,10 @@ export class Component extends OpenShiftItem {
         Component.odo.executeInTerminal(`odo log ${context.getName()} -f --app ${app.getName()} --project ${project.getName()}`);
     }
 
-    static async push(context: OpenShiftObject): Promise<string> {
+    static push(context: OpenShiftObject): void {
         const app: OpenShiftObject = context.getParent();
         const project: OpenShiftObject = app.getParent();
-
-        return Progress.execWithProgress({
-            cancellable: false,
-            location: vscode.ProgressLocation.Notification,
-            title: `Pushing latest changes for component '${context.getName()}'`
-        }, [{command: `odo push ${context.getName()} --app ${app.getName()} --project ${project.getName()}`, increment: 100}
-        ], Component.odo)
-        .then(() => `Successfully pushed changes for '${context.getName()}'`);
+        Component.odo.executeInTerminal(`odo push ${context.getName()} --app ${app.getName()} --project ${project.getName()}`);
     }
 
     static watch(context: OpenShiftObject): void {

test/openshift/component.test.ts

@@ -243,15 +243,9 @@ suite('Openshift/Component', () => {
     });
 
     test('push calls the correct odo command with progress', async () => {
-        const progressStub = sandbox.stub(Progress, 'execWithProgress').resolves();
         const status = await Component.push(componentItem);
-        const steps = [{
-            command: `odo push ${componentItem.getName()} --app ${appItem.getName()} --project ${projectItem.getName()}`,
-            increment: 100
-        }];
 
-        expect(status).equals(`Successfully pushed changes for '${componentItem.getName()}'`);
-        expect(progressStub).calledOnceWith(sinon.match.object, steps);
+        expect(termStub).calledOnceWith(`odo push ${componentItem.getName()} --app ${appItem.getName()} --project ${projectItem.getName()}`);
     });
 
     test('watch calls the correct odo command in terminal', () => {