Skip to content

Check devfile version is 2.0.0 before using it in odo --devfile option #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgolovin opened this issue Mar 13, 2021 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@dgolovin
Copy link
Collaborator

New Component is using devfile.yaml silently without checking what is actually inside it. That approach fails for devfiles v < 2.0.0.

@dgolovin dgolovin added the kind/enhancement New feature or request label Mar 23, 2021
@dgolovin dgolovin added this to the v0.2.5 milestone Mar 23, 2021
@dgolovin dgolovin self-assigned this Mar 23, 2021
@sympatheticmoose
Copy link

@dgolovin so in Che if we have a project with a devfile v1 in, will this change allow a user to create a new component with s2i? Or does odo still detect there's a devfile and still try and fail to apply it (schema validation)?

@dgolovin
Copy link
Collaborator Author

@sympatheticmoose I was not thinking about che at all. Good point. Was actually thinking to backup the devfile v1 and create devfile component after that. This obviously is not going to work well for che.

For components like this we can just show the warning message instead of letting odo to fail. Would that work?

@dgolovin dgolovin modified the milestones: v0.2.5, v0.2.6, v0.2.7 May 4, 2021
@mohitsuman mohitsuman modified the milestones: v0.2.7, 0.2.8 May 11, 2021
@mohitsuman
Copy link
Collaborator

As odo and OpenShift DevSpaces all uses devfile v2. The extension should show the error message that occurs when an older version devfile (v1) is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants