Skip to content

Detect debugger ext for component using devfile's language tags in the registry #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgolovin opened this issue Jun 21, 2022 · 2 comments
Closed

Detect debugger ext for component using devfile's language tags in the registry #2465

dgolovin opened this issue Jun 21, 2022 · 2 comments
Labels
kind/enhancement New feature or request priority/critical
Milestone
1.1.0

Comments

@dgolovin
Copy link
Collaborator

Current implementation is based on keywords in component name and was created as a workaround when devfiles had no tags.
New implementation should detect language and appropriate debugger extension using devfile tags.
@mohitsuman
Copy link
Collaborator

This relates to #2461

@mohitsuman mohitsuman modified the milestones: 0.6.0, 0.7.0 Jul 20, 2022
@mohitsuman mohitsuman modified the milestones: 0.7.0, 0.9.0, 1.2.0, 1.1.0 Sep 15, 2022
@dgolovin
Copy link
Collaborator Author

dgolovin commented Dec 6, 2022

Fixed

vscode-openshift-tools/src/openshift/component.ts

Line 589 in 90adf46

const isJava = component.component.devfileData.devfile.metadata.tags.includes('Java') ;
.

@dgolovin dgolovin closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request priority/critical
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@dgolovin @mohitsuman