Skip to content

Cancel git clone process if user exists Import from Git workflow #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohitsuman opened this issue Nov 28, 2022 · 1 comment · Fixed by #2692
Closed

Cancel git clone process if user exists Import from Git workflow #2681

mohitsuman opened this issue Nov 28, 2022 · 1 comment · Fixed by #2692

Comments

@mohitsuman
Copy link
Collaborator

Currently during Import from Git workflow, if the user cancels the import from git, the cloning process keeps on running in the background. For multiple import from git processes, this can continue. We should find a better way to handle this workflow so that there is no process running concurrently and consuming memory.

@dgolovin
Copy link
Collaborator

dgolovin commented Jan 6, 2023

We need an approach to deal with sudden disposal of webview based editors, because when user closes this king of editors there is no way to stop it. There is no way to cancel closure. All we get is postmortem event didDisposed.

it is not going to be addressed in vscode anytime soon microsoft/vscode#66842.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Adapters Sprint Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
3 participants