Skip to content

Helm Charts doesn't appear in context menu until you switch namespaces #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datho7561 opened this issue Apr 24, 2023 · 1 comment · Fixed by #2851
Closed

Helm Charts doesn't appear in context menu until you switch namespaces #2848

datho7561 opened this issue Apr 24, 2023 · 1 comment · Fixed by #2851
Assignees
Milestone

Comments

@datho7561
Copy link
Contributor

The context menu for opening the Helm Chart view, which appears when right clicking on the cluster in the OpenShift side panel, doesn't appear until you've switched namespaces.

Here is clip demonstrating the issue:

helm-chart-issue.mp4

Note that you can also resolve the issue by "switching namespaces" to the namespace you are currently using. i.e. you are using namespace default, you click switch namespaces and select default, and the issue is resolved.

At the end of the clip, the Helm view is stuck loading, this is unrelated (see #2845) and will be resolved by #2847

@rgrunber
Copy link
Member

rgrunber commented Apr 24, 2023

I think we're just missing void commands.executeCommand('setContext', 'isLoggedIn', true); at a strategic location on initialization.

Things like "Change Active Project" either call

const projectsAndCommand = getOdoInstance().getProjects()
which ultimately end up calling
void commands.executeCommand('setContext', 'isLoggedIn', true);
OR something like "Open Console Dashboard" which has
@vsCommand('openshift.open.developerConsole', true)
@clusterRequired()
, which ends up doing the same.

@msivasubramaniaan msivasubramaniaan added this to the 1.3.0 milestone Apr 25, 2023
@msivasubramaniaan msivasubramaniaan moved this to 📋 Backlog in IDE Cloudaptors Apr 25, 2023
@msivasubramaniaan msivasubramaniaan self-assigned this Apr 25, 2023
@msivasubramaniaan msivasubramaniaan linked a pull request Apr 25, 2023 that will close this issue
@msivasubramaniaan msivasubramaniaan moved this from 📋 Backlog to 🏗 In progress in IDE Cloudaptors Apr 25, 2023
@msivasubramaniaan msivasubramaniaan moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors Apr 25, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants