-
Notifications
You must be signed in to change notification settings - Fork 60
Show Helm charts from all Helm repos in the Helm chart explorer #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think @msivasubramaniaan mentioned he was working on this |
@datho7561 I haven't started yet. I'll pick it for this sprint |
Hello @mohitsuman and @datho7561 When we plan to integrate the CLI approach for getting all the installed Helm repos,
provider, providerType, icon and many more keys were missing. How shall we proceed especially on filter based workflow. Are you guys okay with adding static icons and removing the Provider and Provider Type filtering and moving forward the filtering will be only on repository level. |
IMHO, it's OK to have a static icons. On filtering - does it make sense if we provide filtering by keywords instead by provider and providerType?
|
Thanks @vrubezhny for your input. As my understanding the keyword based filtering not having much values. |
I also think that filtering by repo and keywords is a good idea, and think that the static icons are okay. Somewhat unrelated: Are we using the keywords for the search currently? If not, it might be worthwhile adding something like this. See the Devfile search filtering by tags; I think we could do something similar here in the Helm Chart search code. |
Even keywords were missing on some charts:
Also there were no keywords based filtering on dev console as well. Do the keyword based search really value for the workflow? |
That's ok. In Devfile Registry Search view we show all devfiles in case no a tag is selected in the filter. Once any tags get selected we show the only the Devfiles that have any of the selected tags. So it's still possible to show the Devfiles with no tags set in the search results |
The only Helm repo that is available in the Helm Chart explorer is the OpenShift Helm repo, even if the user has configured additional ones outside of VS Code OpenShift. This is a problem, since many of the charts in the OpenShift Helm repo (including most of the interesting ones like Postgres, Redis, and Jenkins) only work on OpenShift, since they rely on Routes or DeploymentConfigs.
In order to get the extension to work better with other Kubernetes clusters, I think that we should:
There is a mechanism to add/remove Helm repositories in the Kubernetes extension, so I don't think we need to do that as part of this issue.
The text was updated successfully, but these errors were encountered: