Skip to content

Investigate replacing Odo.isPodmanPresent #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datho7561 opened this issue Nov 30, 2023 · 0 comments · Fixed by #3408
Closed

Investigate replacing Odo.isPodmanPresent #3665

datho7561 opened this issue Nov 30, 2023 · 0 comments · Fixed by #3408
Assignees
Labels
Milestone

Comments

@datho7561
Copy link
Contributor

Currently, we use odo version -o json in order to figure out if podman is installed on the user's system.

We depend on a library called which which can be used to search the user's PATH for the podman binary. This means we don't need to rely on odo to check if podman is installed.

We will need to be careful, since on Windows (and I'm guessing macOS as well) odo version -o json reports that podman is not installed if the binary is present, but podman machine doesn't exist. In this PR, I'm trying to improve the error message in this case. We can probably check if the podman machine has been created by using the podman CLI, and alert the user somehow if it isn't.

@datho7561 datho7561 added the debt label Nov 30, 2023
@mohitsuman mohitsuman added this to the 1.12.0 milestone Jan 10, 2024
@mohitsuman mohitsuman moved this to 🏗 In progress in IDE Cloudaptors Jan 10, 2024
@datho7561 datho7561 moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors Jan 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
2 participants