Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish platform-specific binaries & pre-releases to open-vsx.org #739

Closed
datho7561 opened this issue Jul 14, 2022 · 2 comments · Fixed by #840
Closed

Publish platform-specific binaries & pre-releases to open-vsx.org #739

datho7561 opened this issue Jul 14, 2022 · 2 comments · Fixed by #840
Labels
build enhancement New feature or request

Comments

@datho7561
Copy link
Contributor

According to eclipse/openvsx#406, it seems open-vsx.org supports platform-specific extensions. It would be neat if we published platform specific extensions for open-vsx.org as well.

@datho7561 datho7561 added enhancement New feature or request build labels Jul 14, 2022
@rgrunber
Copy link
Member

rgrunber commented Jul 20, 2022

Before we adopt this, we should follow :

https://open-vsx.org/extension/jbangdev/jbang-vscode
https://github.com/jbangdev/jbang-vscode/blob/main/.github/workflows/ci.yaml#L72

and maybe try it out on a flavour of VS Code that uses OpenVSX as the default marketplace.
According to @fbricon , there is no distinction between a release and a pre-release as far as the marketplace goes. We should confirm platform specific vsix work the same way as we expect.

@rgrunber rgrunber changed the title Publish platform-specific binaries to open-vsx.org Publish platform-specific binaries & pre-releases to open-vsx.org Jul 20, 2022
@rgrunber
Copy link
Member

rgrunber commented Aug 31, 2022

At least for pre-releases, there is no distinction currently between itself and a release in the UI. The UI allows installing pre-release as if they were regular releases. redhat-developer/vscode-java#2587 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants